Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1983313002: gn/mac: Add missing test to media_blink_unittests (Closed)

Created:
4 years, 7 months ago by fmenozzi
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn/mac: Add missing test to media_blink_unittests BUG=604060 Committed: https://crrev.com/60dd666a273eb84d361f0fd5de11d770881b46bc Cr-Commit-Position: refs/heads/master@{#394284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fmenozzi
4 years, 7 months ago (2016-05-17 21:49:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983313002/1
4 years, 7 months ago (2016-05-17 21:50:07 UTC) #4
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-17 21:51:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983313002/1
4 years, 7 months ago (2016-05-17 21:53:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 00:30:17 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:31:59 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60dd666a273eb84d361f0fd5de11d770881b46bc
Cr-Commit-Position: refs/heads/master@{#394284}

Powered by Google App Engine
This is Rietveld 408576698