Delay resynthesizing metadata to Impl classes.

Delay resynthesizing metadata to Impl classes.

Now we can restore the disabled metadata validation.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b0f2d80d5a0b96d19922e9a88aae2f84e5290590

[Paul Berry, 2016-05-17 20:45:33]

lgtm

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:431: return _metadata ?? const
<ElementAnnotation>[];
To clarify that this is additional functionality we're layering on top of the
base class, consider doing this instead:

return super.metadata;

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:2736: return _metadata ?? const
<ElementAnnotation>[];
Same suggestion here, and in two additional places below

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1726: ElementAnnotationImpl
elementAnnotation =
It looks like this code has been extracted to
_ResynthesizerContext.buildAnnotation().  Can we replace this with a function
call to avoid introducing duplicate code?

[scheglov, 2016-05-17 21:17:41]

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:431: return _metadata ?? const
<ElementAnnotation>[];
On 2016/05/17 20:45:33, Paul Berry wrote:
> To clarify that this is additional functionality we're layering on top of the
> base class, consider doing this instead:
> 
> return super.metadata;

Done.

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:2736: return _metadata ?? const
<ElementAnnotation>[];
On 2016/05/17 20:45:33, Paul Berry wrote:
> Same suggestion here, and in two additional places below

Done.

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1983293002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1726: ElementAnnotationImpl
elementAnnotation =
On 2016/05/17 20:45:33, Paul Berry wrote:
> It looks like this code has been extracted to
> _ResynthesizerContext.buildAnnotation().  Can we replace this with a function
> call to avoid introducing duplicate code?

Oh, yes, of course!
Thank you for catching this.

[scheglov, 2016-05-17 21:18:19]

Description was changed from

==========
Delay resynthesizing metadata to Impl classes.

Now we can restore the disabled metadata validation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Delay resynthesizing metadata to Impl classes.

Now we can restore the disabled metadata validation.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b0f2d80d5a0b96d19922e9a88aae2f84e5290590
==========

[scheglov, 2016-05-17 21:18:20]

Committed patchset #2 (id:20001) manually as
b0f2d80d5a0b96d19922e9a88aae2f84e5290590 (presubmit successful).

[Brian Wilkerson, 2016-05-17 22:06:08]

lgtm