Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1983243002: Creates mus test helper class (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Creates mus test helper class Moves class that sets up WindowTreeClientImpl that doesn't talk to mus to helper so other tests can use it. BUG=603369 TEST=none R=ben@chromium.org Committed: https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919 Cr-Commit-Position: refs/heads/master@{#394276}

Patch Set 1 #

Patch Set 2 : include converters #

Patch Set 3 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -46 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 5 chunks +30 lines, -14 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 2 chunks +10 lines, -2 lines 0 comments Download
A components/mus/public/cpp/tests/test_window_tree_connection_setup.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A components/mus/public/cpp/tests/test_window_tree_connection_setup.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A components/mus/public/cpp/tests/window_tree_client_impl_private.h View 1 chunk +38 lines, -0 lines 0 comments Download
A components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 2 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
sky
4 years, 7 months ago (2016-05-17 19:17:40 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 7 months ago (2016-05-17 19:24:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983243002/20001
4 years, 7 months ago (2016-05-17 19:37:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/161889)
4 years, 7 months ago (2016-05-17 19:55:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983243002/40001
4 years, 7 months ago (2016-05-17 20:15:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 00:12:05 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:13:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919
Cr-Commit-Position: refs/heads/master@{#394276}

Powered by Google App Engine
This is Rietveld 408576698