third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m - Issue 1983203003: Update third_party/protobuf to protobuf-v3.0.0-beta-3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m

Issue 1983203003: Update third_party/protobuf to protobuf-v3.0.0-beta-3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: owners Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/objectivec/Tests/GPBCodedOuputStreamTests.m ('k') | third_party/protobuf/objectivec/Tests/GPBDictionaryTests.pddm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m

diff --git a/third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m b/third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m

index ccdbb645333c77ee0780d9dcb4eb0ae87f61722d..a1923c9cc4ccb45d42a95189f369ba8f4f21bcd7 100644

--- a/third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m

+++ b/third_party/protobuf/objectivec/Tests/GPBDescriptorTests.m

@@ -153,19 +153,6 @@

XCTAssertFalse([fieldDescriptor isValidEnumValue:-2]);

}

-- (void)testEnumDescriptorLookup {

- GPBDescriptor *descriptor = [TestAllTypes descriptor];

- GPBEnumDescriptor *enumDescriptor =

- [descriptor enumWithName:@"TestAllTypes_NestedEnum"];

- XCTAssertNotNil(enumDescriptor);

- // Descriptor cannot find foreign or imported enums.

- enumDescriptor = [descriptor enumWithName:@"ForeignEnumEnum"];

- XCTAssertNil(enumDescriptor);

- enumDescriptor = [descriptor enumWithName:@"ImportEnumEnum"];

- XCTAssertNil(enumDescriptor);

- (void)testOneofDescriptor {

GPBDescriptor *descriptor = [TestOneof2 descriptor];