third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc - Issue 1983203003: Update third_party/protobuf to protobuf-v3.0.0-beta-3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc

Issue 1983203003: Update third_party/protobuf to protobuf-v3.0.0-beta-3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: owners Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/compiler/java/java_message_builder_lite.cc ('k') | third_party/protobuf/src/google/protobuf/compiler/java/java_message_field_lite.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc

diff --git a/third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc b/third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc

index b5f8e626fdd54073f0575baabc0a7470832c8f5f..455516f67756acd2f14e255ced79c8485e779ac3 100644

--- a/third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc

+++ b/third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.cc

@@ -70,8 +70,7 @@ void SetMessageVariables(const FieldDescriptor* descriptor,

// by the proto compiler

(*variables)["deprecation"] = descriptor->options().deprecated()

? "@java.lang.Deprecated " : "";

- (*variables)["on_changed"] =

- HasDescriptorMethods(descriptor->containing_type()) ? "onChanged();" : "";

+ (*variables)["on_changed"] = "onChanged();";

if (SupportFieldPresence(descriptor->file())) {

// For singular messages and builders, one bit is used for the hasField bit.