| Index: third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs
|
| diff --git a/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs b/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs
|
| index 082f7432fe6f56ed592bfed8df886821896950d8..f4fac73865c16a5399cbdc78a4f076aeeec9e29e 100644
|
| --- a/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs
|
| +++ b/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs
|
| @@ -36,11 +36,27 @@ namespace Google.Protobuf.WellKnownTypes
|
| {
|
| public partial class Any
|
| {
|
| + private const string DefaultPrefix = "type.googleapis.com";
|
| +
|
| // This could be moved to MessageDescriptor if we wanted to, but keeping it here means
|
| // all the Any-specific code is in the same place.
|
| - private static string GetTypeUrl(MessageDescriptor descriptor)
|
| + private static string GetTypeUrl(MessageDescriptor descriptor, string prefix) =>
|
| + prefix.EndsWith("/") ? prefix + descriptor.FullName : prefix + "/" + descriptor.FullName;
|
| +
|
| + /// <summary>
|
| + /// Retrieves the type name for a type URL. This is always just the last part of the URL,
|
| + /// after the trailing slash. No validation of anything before the trailing slash is performed.
|
| + /// If the type URL does not include a slash, an empty string is returned rather than an exception
|
| + /// being thrown; this won't match any types, and the calling code is probably in a better position
|
| + /// to give a meaningful error.
|
| + /// There is no handling of fragments or queries at the moment.
|
| + /// </summary>
|
| + /// <param name="typeUrl">The URL to extract the type name from</param>
|
| + /// <returns>The type name</returns>
|
| + internal static string GetTypeName(string typeUrl)
|
| {
|
| - return "type.googleapis.com/" + descriptor.FullName;
|
| + int lastSlash = typeUrl.LastIndexOf('/');
|
| + return lastSlash == -1 ? "" : typeUrl.Substring(lastSlash + 1);
|
| }
|
|
|
| /// <summary>
|
| @@ -55,25 +71,37 @@ namespace Google.Protobuf.WellKnownTypes
|
| // Note: this doesn't perform as well is it might. We could take a MessageParser<T> in an alternative overload,
|
| // which would be expected to perform slightly better... although the difference is likely to be negligible.
|
| T target = new T();
|
| - string targetTypeUrl = GetTypeUrl(target.Descriptor);
|
| - if (TypeUrl != targetTypeUrl)
|
| + if (GetTypeName(TypeUrl) != target.Descriptor.FullName)
|
| {
|
| - throw new InvalidProtocolBufferException(string.Format("Type url for {0} is {1}; Any message's type url is {2}",
|
| - target.Descriptor.Name, targetTypeUrl, TypeUrl));
|
| + throw new InvalidProtocolBufferException(
|
| + $"Full type name for {target.Descriptor.Name} is {target.Descriptor.FullName}; Any message's type url is {TypeUrl}");
|
| }
|
| target.MergeFrom(Value);
|
| return target;
|
| }
|
|
|
| /// <summary>
|
| - /// Packs the specified message into an Any message.
|
| + /// Packs the specified message into an Any message using a type URL prefix of "type.googleapis.com".
|
| + /// </summary>
|
| + /// <param name="message">The message to pack.</param>
|
| + /// <returns>An Any message with the content and type URL of <paramref name="message"/>.</returns>
|
| + public static Any Pack(IMessage message) => Pack(message, DefaultPrefix);
|
| +
|
| + /// <summary>
|
| + /// Packs the specified message into an Any message using the specified type URL prefix.
|
| /// </summary>
|
| /// <param name="message">The message to pack.</param>
|
| + /// <param name="typeUrlPrefix">The prefix for the type URL.</param>
|
| /// <returns>An Any message with the content and type URL of <paramref name="message"/>.</returns>
|
| - public static Any Pack(IMessage message)
|
| + public static Any Pack(IMessage message, string typeUrlPrefix)
|
| {
|
| - Preconditions.CheckNotNull(message, "message");
|
| - return new Any { TypeUrl = GetTypeUrl(message.Descriptor), Value = message.ToByteString() };
|
| + ProtoPreconditions.CheckNotNull(message, nameof(message));
|
| + ProtoPreconditions.CheckNotNull(typeUrlPrefix, nameof(typeUrlPrefix));
|
| + return new Any
|
| + {
|
| + TypeUrl = GetTypeUrl(message.Descriptor, typeUrlPrefix),
|
| + Value = message.ToByteString()
|
| + };
|
| }
|
| }
|
| }
|
|
|