Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: media/capture/video/video_capture_device_unittest.cc

Issue 1983193002: Decouple capture timestamp and reference time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve Comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/capture/video/video_capture_device.h ('k') | media/capture/video/win/sink_filter_observer_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/video_capture_device_unittest.cc
diff --git a/media/capture/video/video_capture_device_unittest.cc b/media/capture/video/video_capture_device_unittest.cc
index 85e271813295232850bb2a1219153e1bc55da769..fd2a2ceff34350938fa455c87f83c3781a5855e0 100644
--- a/media/capture/video/video_capture_device_unittest.cc
+++ b/media/capture/video/video_capture_device_unittest.cc
@@ -73,16 +73,6 @@ static const gfx::Size kCaptureSizes[] = {gfx::Size(640, 480),
class MockClient : public VideoCaptureDevice::Client {
public:
- MOCK_METHOD9(OnIncomingCapturedYuvData,
- void(const uint8_t* y_data,
- const uint8_t* u_data,
- const uint8_t* v_data,
- size_t y_stride,
- size_t u_stride,
- size_t v_stride,
- const VideoCaptureFormat& frame_format,
- int clockwise_rotation,
- const base::TimeTicks& timestamp));
MOCK_METHOD0(DoReserveOutputBuffer, void(void));
MOCK_METHOD0(DoOnIncomingCapturedBuffer, void(void));
MOCK_METHOD0(DoOnIncomingCapturedVideoFrame, void(void));
@@ -100,7 +90,8 @@ class MockClient : public VideoCaptureDevice::Client {
int length,
const VideoCaptureFormat& format,
int rotation,
- const base::TimeTicks& timestamp) override {
+ base::TimeTicks reference_time,
+ base::TimeDelta timestamp) override {
ASSERT_GT(length, 0);
ASSERT_TRUE(data != NULL);
main_thread_->PostTask(FROM_HERE, base::Bind(frame_cb_, format));
@@ -117,12 +108,13 @@ class MockClient : public VideoCaptureDevice::Client {
}
void OnIncomingCapturedBuffer(std::unique_ptr<Buffer> buffer,
const VideoCaptureFormat& frame_format,
- const base::TimeTicks& timestamp) override {
+ base::TimeTicks reference_time,
+ base::TimeDelta timestamp) override {
DoOnIncomingCapturedBuffer();
}
void OnIncomingCapturedVideoFrame(std::unique_ptr<Buffer> buffer,
const scoped_refptr<VideoFrame>& frame,
- const base::TimeTicks& timestamp) override {
+ base::TimeTicks reference_time) override {
DoOnIncomingCapturedVideoFrame();
}
std::unique_ptr<Buffer> ResurrectLastOutputBuffer(
@@ -179,8 +171,6 @@ class VideoCaptureDeviceTest : public testing::TestWithParam<gfx::Size> {
#if defined(OS_MACOSX)
AVFoundationGlue::InitializeAVFoundation();
#endif
- EXPECT_CALL(*client_, OnIncomingCapturedYuvData(_, _, _, _, _, _, _, _, _))
- .Times(0);
EXPECT_CALL(*client_, DoReserveOutputBuffer()).Times(0);
EXPECT_CALL(*client_, DoOnIncomingCapturedBuffer()).Times(0);
EXPECT_CALL(*client_, DoOnIncomingCapturedVideoFrame()).Times(0);
« no previous file with comments | « media/capture/video/video_capture_device.h ('k') | media/capture/video/win/sink_filter_observer_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698