Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

Issue 1983193002: Decouple capture timestamp and reference time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve Comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/web_contents_video_capture_device_unittest.cc
diff --git a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
index 1babd42075a98aa3dcb9468f86797a023eef19ac..4f06d89421ce24be0173e557456740b908f8bc30 100644
--- a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
+++ b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
@@ -336,22 +336,13 @@ class StubClient : public media::VideoCaptureDevice::Client {
}
~StubClient() override {}
- MOCK_METHOD5(OnIncomingCapturedData,
+ MOCK_METHOD6(OnIncomingCapturedData,
void(const uint8_t* data,
int length,
const media::VideoCaptureFormat& frame_format,
int rotation,
- const base::TimeTicks& timestamp));
- MOCK_METHOD9(OnIncomingCapturedYuvData,
- void(const uint8_t* y_data,
- const uint8_t* u_data,
- const uint8_t* v_data,
- size_t y_stride,
- size_t u_stride,
- size_t v_stride,
- const media::VideoCaptureFormat& frame_format,
- int clockwise_rotation,
- const base::TimeTicks& timestamp));
+ base::TimeTicks reference_time,
+ base::TimeDelta timestamp));
MOCK_METHOD0(DoOnIncomingCapturedBuffer, void(void));
@@ -374,14 +365,15 @@ class StubClient : public media::VideoCaptureDevice::Client {
// Trampoline method to workaround GMOCK problems with std::unique_ptr<>.
void OnIncomingCapturedBuffer(std::unique_ptr<Buffer> buffer,
const media::VideoCaptureFormat& frame_format,
- const base::TimeTicks& timestamp) override {
+ base::TimeTicks reference_time,
+ base::TimeDelta timestamp) override {
DoOnIncomingCapturedBuffer();
}
void OnIncomingCapturedVideoFrame(
std::unique_ptr<Buffer> buffer,
const scoped_refptr<media::VideoFrame>& frame,
- const base::TimeTicks& timestamp) override {
+ base::TimeTicks reference_time) override {
EXPECT_FALSE(frame->visible_rect().IsEmpty());
EXPECT_EQ(media::PIXEL_FORMAT_I420, frame->format());
double frame_rate = 0;

Powered by Google App Engine
This is Rietveld 408576698