Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1983183003: Do not try to load "guestViewIframe" module when guest view internal isn't (Closed)

Created:
4 years, 7 months ago by lazyboy
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not try to load "guestViewIframe" module when guest view internal isn't required. BUG=612617 Test=Start chromium, you shouldn't see any warning like this one: chrome.guestViewInternal is not available:... Committed: https://crrev.com/dd968e7e16f01d7062734ae66f74794a6a91c324 Cr-Commit-Position: refs/heads/master@{#394311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M extensions/renderer/dispatcher.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
lazyboy
4 years, 7 months ago (2016-05-17 22:41:15 UTC) #2
lfg
Ah, good catch. lgtm.
4 years, 7 months ago (2016-05-17 22:50:06 UTC) #3
lazyboy
+Antony for OWNERS
4 years, 7 months ago (2016-05-17 23:06:17 UTC) #5
asargent_no_longer_on_chrome
lgtm
4 years, 7 months ago (2016-05-18 00:16:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983183003/1
4 years, 7 months ago (2016-05-18 00:50:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 01:44:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 01:45:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd968e7e16f01d7062734ae66f74794a6a91c324
Cr-Commit-Position: refs/heads/master@{#394311}

Powered by Google App Engine
This is Rietveld 408576698