Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1983163002: [Mac/GN] Change two ldlfags to libs. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Robert Sesek
4 years, 7 months ago (2016-05-17 17:40:31 UTC) #1
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-17 18:04:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45f4df17be3db78b635f8e745ec9273384b10fe5 Cr-Commit-Position: refs/heads/master@{#394181}
4 years, 7 months ago (2016-05-17 19:09:33 UTC) #5
Robert Sesek
4 years, 7 months ago (2016-05-17 19:12:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45f4df17be3db78b635f8e745ec9273384b10fe5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698