Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1983153003: Use a temp directory for the temporary files that the tests create. (Closed)

Created:
4 years, 7 months ago by vakh (use Gerrit instead)
Modified:
4 years, 7 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a temp directory for the temporary files that the tests create. BUG=612296 Committed: https://crrev.com/a1d3a937bb232bef874e846f4f5378f23554e27e Cr-Commit-Position: refs/heads/master@{#395277}

Patch Set 1 #

Patch Set 2 : Provide a way to PrepareBasicDownloadItem with full paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 6 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vakh (use Gerrit instead)
4 years, 7 months ago (2016-05-17 18:49:59 UTC) #2
Nathan Parker
lgtm Better!
4 years, 7 months ago (2016-05-17 19:17:30 UTC) #3
vakh (use Gerrit instead)
Provide a way to PrepareBasicDownloadItem with full paths
4 years, 7 months ago (2016-05-17 20:20:08 UTC) #4
vakh (use Gerrit instead)
PTAL
4 years, 7 months ago (2016-05-17 20:39:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983153003/20001
4 years, 7 months ago (2016-05-22 22:29:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-22 23:41:27 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-22 23:42:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1d3a937bb232bef874e846f4f5378f23554e27e
Cr-Commit-Position: refs/heads/master@{#395277}

Powered by Google App Engine
This is Rietveld 408576698