Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1983153002: Change ClassElementForLink.getContainedName() to include non-static members. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change ClassElementForLink.getContainedName() to include non-static members. This is necessary because ClassElementForLink.getContainedName() is used to access non-static members when resynthesizing references from a summary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/39d184f2f327d2e5bff440ed7caff916fd31e393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-17 17:37:29 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-17 17:46:57 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-17 18:34:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
39d184f2f327d2e5bff440ed7caff916fd31e393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698