Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1983123002: Fix UploadDataProviders.create(byte[], offset, count) (Closed)

Created:
4 years, 7 months ago by xunjieli
Modified:
4 years, 7 months ago
Reviewers:
mgersh
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UploadDataProviders.create(byte[], offset, count) This CL makes UploadDataProviders.create(byte[], offset, count) create a ByteBuffer with position 0, so when rewind() is called, resetting the position back to 0 doesn't break things. BUG=603124 Committed: https://crrev.com/e3db5466956f058d7a69c33452a543a15261080d Cr-Commit-Position: refs/heads/master@{#394193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M components/cronet/android/api/src/org/chromium/net/UploadDataProviders.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xunjieli
Miriam, mind reviewing a small patch?
4 years, 7 months ago (2016-05-17 17:10:13 UTC) #3
mgersh
On 2016/05/17 17:10:13, xunjieli wrote: > Miriam, mind reviewing a small patch? Sure! lgtm.
4 years, 7 months ago (2016-05-17 18:41:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983123002/1
4 years, 7 months ago (2016-05-17 18:43:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 19:40:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 19:44:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3db5466956f058d7a69c33452a543a15261080d
Cr-Commit-Position: refs/heads/master@{#394193}

Powered by Google App Engine
This is Rietveld 408576698