Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1983093002: [gn] Port more build flags for gn (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Port more build flags for gn BUG=chromium:474921 LOG=n NOTRY=true Committed: https://crrev.com/0151651603ce7ba0f23df4699692984248ae8b12 Cr-Commit-Position: refs/heads/master@{#36293}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build_overrides/v8.gni View 1 chunk +14 lines, -0 lines 3 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1983093002/diff/1/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/1983093002/diff/1/build_overrides/v8.gni#newcode13 build_overrides/v8.gni:13: # V8 generates code for this architecture. This ...
4 years, 7 months ago (2016-05-17 15:15:44 UTC) #4
vogelheim
lgtm Thanks for the annotations; those are hugely helpful to determine what's going on. :-)
4 years, 7 months ago (2016-05-17 16:05:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983093002/1
4 years, 7 months ago (2016-05-17 19:37:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 19:39:19 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 19:40:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0151651603ce7ba0f23df4699692984248ae8b12
Cr-Commit-Position: refs/heads/master@{#36293}

Powered by Google App Engine
This is Rietveld 408576698