Query the existence other forms of browsing history.

components/browsing_data_ui/history_notice_utils.h

Index: components/browsing_data_ui/history_notice_utils.h
diff --git a/components/browsing_data_ui/history_notice_utils.h b/components/browsing_data_ui/history_notice_utils.h
index c3ab520d5ee69269011cda7091867744b72f8f89..67c5671be623ee9faaf3ecbfa4a848db6ddf26be 100644
--- a/components/browsing_data_ui/history_notice_utils.h
+++ b/components/browsing_data_ui/history_notice_utils.h
@@ -5,6 +5,8 @@
 #ifndef COMPONENTS_BROWSING_DATA_UI_HISTORY_NOTICE_UTILS_H_
 #define COMPONENTS_BROWSING_DATA_UI_HISTORY_NOTICE_UTILS_H_
 
+#include <string>
+
 #include "base/callback_forward.h"
 
 class ProfileSyncService;
@@ -13,6 +15,10 @@ namespace history {
 class WebHistoryService;
 }
 
+namespace version_info {
+enum class Channel;
+}
+
 namespace browsing_data_ui {
 
 namespace testing {
@@ -23,7 +29,7 @@ namespace testing {
 // found. Used only for testing. The default is false.
 extern bool g_override_other_forms_of_browsing_history_query;
 
-}
+}  // testing
 
 // Whether the Clear Browsing Data UI should show a notice about the existence
 // of other forms of browsing history stored in user's account. The response
@@ -36,10 +42,14 @@ void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
 // Whether the Clear Browsing Data UI should popup a dialog with information
 // about the existence of other forms of browsing history stored in user's
 // account when the user deletes their browsing history for the first time.
-// The response is returned in a |callback|.
+// The response is returned in a |callback|. The |channel| and |user_agent|
+// must be provided for successful communication with the Sync server, but
+// the result does not depend from them.
 void ShouldPopupDialogAboutOtherFormsOfBrowsingHistory(
     const ProfileSyncService* sync_service,
     history::WebHistoryService* history_service,
+    const version_info::Channel channel,

[msarda, 2016/05/18 08:58:07]

Is this missing a reference:  const version_info::Channel& channel ?

[sdefresne, 2016/05/18 14:29:41]

no version_info::Channel is an enum value, no need to pass by reference (it's an
int)

[msarda, 2016/05/18 14:32:54]

Do we need the const then?

[msramek, 2016/05/18 19:38:37]

Correct, this is an extra const, it's not needed. Done.

+    const std::string& user_agent,
     base::Callback<void(bool)> callback);
 
 }  // namespace browsing_data_ui