components/ntp_tiles/DEPS - Issue 1983063002: Move classes to //components/ntp_tiles.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_tiles/DEPS

Issue 1983063002: Move classes to //components/ntp_tiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/snippets/tiles/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+components/google/core/browser",

	3 "+components/history/core/browser",

	4 "+components/pref_registry",

	5 "+components/prefs",

	6 "+components/safe_json",

	7 "+components/search_engines",

	8 "+components/suggestions",

	9 "+components/variations",

	10 "+content/public/browser",
	sdefresne 2016/05/24 06:36:32 Is there plan to use this component on iOS? If yes Is there plan to use this component on iOS? If yes, I would recommend removing the dependency on //content/public/browser before moving this code into the component. It looks like the only dependency is on content::BrowserThread which is easy to abstract by injecting the threads into the object at creation (see all the other layered components). If no, what are the different embedders that will use this component? sfiera 2016/05/24 12:40:15 Our immediate plan is to use it in the desktop new Show quoted text On 2016/05/24 06:36:32, sdefresne wrote: > Is there plan to use this component on iOS? If yes, I would recommend removing > the dependency on //content/public/browser before moving this code into the > component. It looks like the only dependency is on content::BrowserThread which > is easy to abstract by injecting the threads into the object at creation (see > all the other layered components). > > If no, what are the different embedders that will use this component? Our immediate plan is to use it in the desktop new tab page; we haven't made any plans to use it on iOS. We might eventually want to, but it would be a few quarters out at least. Marc Treib 2016/05/24 12:46:35 I guess the main blocker is that nobody on our tea Show quoted text On 2016/05/24 12:40:15, sfiera wrote: > On 2016/05/24 06:36:32, sdefresne wrote: > > Is there plan to use this component on iOS? If yes, I would recommend removing > > the dependency on //content/public/browser before moving this code into the > > component. It looks like the only dependency is on content::BrowserThread > which > > is easy to abstract by injecting the threads into the object at creation (see > > all the other layered components). > > > > If no, what are the different embedders that will use this component? > > Our immediate plan is to use it in the desktop new tab page; we haven't made any > plans to use it on iOS. We might eventually want to, but it would be a few > quarters out at least. I guess the main blocker is that nobody on our team has experience with iOS. If somebody from the iOS team wants to do the integration work, then I'm sure we can make that happen in less than a few quarters :) Not in this CL though.
	11 "+google_apis",

	12 "+net/base",

	13 "+net/http",

	14 "+net/url_request",

	15 "+third_party/skia/include",

	16 "+ui/gfx",

	17 ]

OLD	NEW

« components/ntp_tiles/BUILD.gn ('K') | « components/ntp_tiles/BUILD.gn ('k') | components/ntp_tiles/most_visited_sites.h » ('j') | no next file with comments »