Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 198303002: Reland "Avoid hitting the thread check when WebRtcAudioRenderer is going away" (Closed)

Created:
6 years, 9 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Reland "Avoid hitting the thread check when WebRtcAudioRenderer is going away" This relands r255158 without including the changes to webrtc_audio_renderer.cc. This prevents audio loss from occuring in other WebRTC apps. Setting notry=true because this is essentially just reverting the revert I made about an hour ago. > Avoid hitting the thread check when WebRtcAudioRenderer is going away. > > We need to reset the render_thread_checker and render_converter_ when the WebRtcAudioRenderer is going away. > > NOTRY=true > > BUG=264611 > TEST=manual test webrtc with --enable-audio-track-processor NOTRY=true BUG=351895, 264611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/renderer/media/media_stream_audio_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 9 months ago (2014-03-12 23:04:04 UTC) #1
no longer working on chromium
On 2014/03/12 23:04:04, Victoria Kirst wrote: lgtm
6 years, 9 months ago (2014-03-12 23:05:10 UTC) #2
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 9 months ago (2014-03-12 23:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/198303002/1
6 years, 9 months ago (2014-03-12 23:15:22 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 23:18:53 UTC) #5
Message was sent while issue was closed.
Change committed as 256694

Powered by Google App Engine
This is Rietveld 408576698