Add CustomElementState for Custom Elements v1

third_party/WebKit/Source/core/dom/NodeTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/Node.h"
 
 #include "core/editing/EditingTestBase.h"
 
 namespace blink {
 
@@ skipping 18 matching lines @@
     const char* bodyContent = "<div id=host><span id=one>one</span></div>";
     const char* shadowContent = "<a href='http://www.msn.com'><content></content></a>";
     setBodyContent(bodyContent);
     setShadowContent(shadowContent, "host");
     Node* one = document().getElementById("one");
 
     EXPECT_FALSE(one->canStartSelection());
     EXPECT_FALSE(one->firstChild()->canStartSelection());
 }
 
+TEST_F(NodeTest, customElementState)
+{
+    const char* bodyContent = "<div id=div></div>";
+    setBodyContent(bodyContent);
+    Element* div = document().getElementById("div");
+    EXPECT_EQ(CustomElementState::Uncustomized, div->getCustomElementState());
+    EXPECT_TRUE(div->isDefinedCustomElement());

[dominicc (has gone to gerrit), 2016/05/18 07:56:22]

I think in practice code needs to distinguish three or four states:

Not a custom element
A custom element that's not defined/upgraded (* not sure exactly what we need
here)
A custom element that's "done"

[kojii, 2016/05/18 08:32:15]

When you need to distinguish the three, getCustomElementState() is what you
need:
Not a custom element -> uncustomized
A custom element that's not defined/upgraded -> undefined
A custom element that's "done" -> customized

The spec also defines a state group:
"uncustomized" or "custom" -> defined
so isDefinedCustomElement() is when I need to know whether it's defined or not.

...or did I misunderstand your comment? Could you elaborate if I look so?

+    EXPECT_EQ(Node::V0NotCustomElement, div->getV0CustomElementState());
+
+    div->setCustomElementState(CustomElementState::Undefined);
+    EXPECT_EQ(CustomElementState::Undefined, div->getCustomElementState());
+    EXPECT_FALSE(div->isDefinedCustomElement());
+    EXPECT_EQ(Node::V0NotCustomElement, div->getV0CustomElementState());
+
+    div->setCustomElementState(CustomElementState::Customized);
+    EXPECT_EQ(CustomElementState::Customized, div->getCustomElementState());
+    EXPECT_TRUE(div->isDefinedCustomElement());
+    EXPECT_EQ(Node::V0NotCustomElement, div->getV0CustomElementState());
+}
+
 } // namespace blink