Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1982963002: Reland: mus: Add views_mus_interactive_ui_tests target (Closed)

Created:
4 years, 7 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: mus: Add views_mus_interactive_ui_tests target Previous attempt had a size_t to int warning on Windows, which was suppressed in chrome's interactive_ui_tests but not this new target. See https://codereview.chromium.org/1972363002/ * Run widget_interactive_uitests.cc in the new target. * Added a shared "test_support" target in ui/views/mus. * Pull ViewsMusTestSuite into its own file so I can share it. * Also make ViewsTestBase::IsMus static so I can call it before the PlatformTestHelper is initialized. * Disable a bunch of tests that fail on mus (I filed bugs for them). * Fix an unnecessary size_t to int conversion BUG=602036 TEST=views_mus_interactive_ui_tests on mus, interactive_ui_tests elsewhere TBR=sky@chromium.org, dpranke@chromium.org, sadrul@chromium.org Committed: https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77 Cr-Commit-Position: refs/heads/master@{#394153}

Patch Set 1 #

Patch Set 2 : fix size_t to int warning on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -227 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mojo.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/mus/BUILD.gn View 6 chunks +88 lines, -19 lines 0 comments Download
M ui/views/mus/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + ui/views/mus/interactive_ui_tests_manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download
A + ui/views/mus/interactive_ui_tests_mus.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M ui/views/mus/run_all_unittests_mus.cc View 1 chunk +2 lines, -137 lines 0 comments Download
A ui/views/mus/views_mus_test_suite.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + ui/views/mus/views_mus_test_suite.cc View 7 chunks +27 lines, -29 lines 0 comments Download
M ui/views/run_all_unittests.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/run_all_unittests.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/test/platform_test_helper.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/test/platform_test_helper.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/test/views_test_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 10 chunks +53 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982963002/20001
4 years, 7 months ago (2016-05-17 16:06:14 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 17:22:09 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ba13ca8e09763be3d4a93ef3d2d495aa806ddd77 Cr-Commit-Position: refs/heads/master@{#394153}
4 years, 7 months ago (2016-05-17 17:23:39 UTC) #8
qyearsley
4 years, 7 months ago (2016-05-17 17:50:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1984403002/ by qyearsley@chromium.org.

The reason for reverting is: Speculative revert for compile failure on Win:
https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/43482.

Powered by Google App Engine
This is Rietveld 408576698