Drag images should paint descendants that are painting siblings of the dragged element

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 599 matching lines @@
     return ratio;
 }
 
 PassOwnPtr<DragImage> LocalFrame::nodeImage(Node& node)
 {
     m_view->updateAllLifecyclePhasesExceptPaint();
     LayoutObject* layoutObject = node.layoutObject();
     if (!layoutObject)
         return nullptr;
 
-    // Paint starting at the nearest self painting layer, clipped to the object itself.
+    // Paint starting at the nearest stacking context, clipped to the object itself.

[chrishtr, 2016/05/19 17:45:16]

I wonder if we should explicitly clip now, to avoid over-painting of ancestors.

[trchen, 2016/05/23 19:37:53]

As discussed offline, it is already clipped.

     // TODO(pdr): This will also paint the content behind the object if the object contains

[chrishtr, 2016/05/19 17:46:52]

I'd change this to a note instead of a TODO. There is now no intention to "fix"
it.

[trchen, 2016/05/23 19:37:53]

Done.

     // transparency but the layer is opaque. We could directly call layoutObject->paint(...)
     // (see ObjectPainter::paintAllPhasesAtomically) but this would skip self-painting children.
-    PaintLayer* layer = layoutObject->enclosingLayer()->enclosingSelfPaintingLayer();
+    PaintLayer* layer = layoutObject->enclosingLayer();
+    if (!layer->stackingNode()->isStackingContext())
+        layer = layer->stackingNode()->ancestorStackingContextNode()->layer();
     IntRect absoluteBoundingBox = layoutObject->absoluteBoundingBoxRectIncludingDescendants();
     FloatRect boundingBox = layer->layoutObject()->absoluteToLocalQuad(FloatQuad(absoluteBoundingBox), UseTransforms).boundingBox();
     DragImageBuilder dragImageBuilder(this, boundingBox, &node);
     {
-        PaintLayerPaintingInfo paintingInfo(layer, LayoutRect(boundingBox), GlobalPaintFlattenCompositingLayers, LayoutSize(), 0);
+        PaintLayerPaintingInfo paintingInfo(layer, LayoutRect(boundingBox), GlobalPaintFlattenCompositingLayers, LayoutSize());
         PaintLayerFlags flags = PaintLayerHaveTransparency | PaintLayerAppliedTransform | PaintLayerUncachedClipRects;
         PaintLayerPainter(*layer).paintLayer(dragImageBuilder.context(), paintingInfo, flags);
     }
     return dragImageBuilder.createImage();
 }
 
 PassOwnPtr<DragImage> LocalFrame::dragImageForSelection(float opacity)
 {
     if (!selection().isRange())
         return nullptr;
@@ skipping 167 matching lines @@
 {
     m_frame->disableNavigation();
 }
 
 FrameNavigationDisabler::~FrameNavigationDisabler()
 {
     m_frame->enableNavigation();
 }
 
 } // namespace blink