third_party/WebKit/LayoutTests/fast/dom/css-shorthand-common-value.html - Issue 1982903002: Fix 'border' serialization to fail in cssText when it is invalid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/css-shorthand-common-value.html

Issue 1982903002: Fix 'border' serialization to fail in cssText when it is invalid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getPropertyValue-border-expected.txt ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <style>	2 <style>

3 #test {	3 #test {

4 border: 10px solid red;	4 border: 10px solid red;

5 border-top-width: 50px;	5 border-top-width: 50px;

6 }	6 }

7 </style>	7 </style>

8 <p>getPropertyValue('border') should not return a value for any property that do esn't have the same value for top, left, right and bottom, even if the values th at differ are implicitly set by a shorthand.	8 <p>getPropertyValue('border') should not return a value for any property that do esn't have the same value for top, left, right and bottom, even if the values th at differ are implicitly set by a shorthand.
	Timothy Loh 2016/05/17 01:53:53 Interestingly, this description was here since thi Interestingly, this description was here since this test's inception but the test itself was always incorrect.
9 <pre id="result">	9 <pre id="result">

10 </pre>	10 </pre>

11	11

12 <script>	12 <script>

13 if (window.testRunner)	13 if (window.testRunner)

14 testRunner.dumpAsText();	14 testRunner.dumpAsText();

15 var sheet = document.querySelector('style').sheet;	15 var sheet = document.querySelector('style').sheet;

16 var expected = 'solid red';	16 var expected = '';

17 var actual = sheet.cssRules[0].style.getPropertyValue('border');	17 var actual = sheet.cssRules[0].style.getPropertyValue('border');

18	18

19 if (expected == actual)	19 if (expected == actual)

20 document.getElementById('result').innerText = 'PASS';	20 document.getElementById('result').innerText = 'PASS';

21 else	21 else

22 document.getElementById('result').innerText = 'FAIL: expected "' + expected + '", got "' + actual + '"';	22 document.getElementById('result').innerText = 'FAIL: expected "' + expected + '", got "' + actual + '"';

23	23

24 </script>	24 </script>

25	25

OLD	NEW