Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: blimp/engine/renderer/engine_image_serialization_processor.cc

Issue 1982893002: [blimp] Add SkPicture caching support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix memory leak by adding virtual destructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/renderer/engine_image_serialization_processor.cc
diff --git a/blimp/engine/renderer/engine_image_serialization_processor.cc b/blimp/engine/renderer/engine_image_serialization_processor.cc
index 7d745016700d60eeeae164576a4888181f20c937..7cf8af86a93d97cec2e4859759667e09f13aaefa 100644
--- a/blimp/engine/renderer/engine_image_serialization_processor.cc
+++ b/blimp/engine/renderer/engine_image_serialization_processor.cc
@@ -11,11 +11,14 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/trace_event/trace_event.h"
#include "blimp/common/blob_cache/id_util.h"
#include "blimp/common/proto/blob_cache.pb.h"
+#include "blimp/engine/renderer/blimp_engine_picture_cache.h"
#include "blimp/engine/renderer/blob_channel_sender_proxy.h"
+#include "cc/proto/picture_cache.h"
#include "content/public/renderer/render_frame.h"
#include "third_party/libwebp/webp/encode.h"
#include "third_party/skia/include/core/SkData.h"
@@ -96,12 +99,13 @@ EngineImageSerializationProcessor::~EngineImageSerializationProcessor() {
WebPMemoryWriterClear(&writer_state_);
}
-SkPixelSerializer* EngineImageSerializationProcessor::GetPixelSerializer() {
- return this;
+std::unique_ptr<cc::EnginePictureCache>
+EngineImageSerializationProcessor::CreateEnginePictureCache() {
+ return base::WrapUnique(new BlimpEnginePictureCache(this));
}
-SkPicture::InstallPixelRefProc
-EngineImageSerializationProcessor::GetPixelDeserializer() {
+std::unique_ptr<cc::ClientPictureCache>
+EngineImageSerializationProcessor::CreateClientPictureCache() {
Kevin M 2016/06/17 17:53:38 Add NOTREACHED() here?
nyquist 2016/06/17 21:31:43 Done.
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698