Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6096)

Unified Diff: blimp/engine/renderer/engine_image_serialization_processor.h

Issue 1982893002: [blimp] Add SkPicture caching support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from kmarshall Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/renderer/engine_image_serialization_processor.h
diff --git a/blimp/engine/renderer/engine_image_serialization_processor.h b/blimp/engine/renderer/engine_image_serialization_processor.h
index d400704b15f52da6187b841a42a9fe9adf5a8b65..db245e0fc28d70e64364b0ce6f404e2b4f6a57c8 100644
--- a/blimp/engine/renderer/engine_image_serialization_processor.h
+++ b/blimp/engine/renderer/engine_image_serialization_processor.h
@@ -11,7 +11,7 @@
#include "blimp/common/blimp_common_export.h"
#include "blimp/engine/mojo/blob_channel.mojom.h"
#include "cc/proto/image_serialization_processor.h"
-#include "third_party/skia/include/core/SkPicture.h"
+#include "cc/proto/picture_cache.h"
class SkPixelSerializer;
@@ -22,8 +22,8 @@ class RenderFrame;
namespace blimp {
namespace engine {
-// EngineImageSerializationProcessor provides functionality to serialize and
-// deserialize Skia images.
+// EngineImageSerializationProcessor provides functionality to serialize
+// and temporarily cache Skia images.
class BLIMP_COMMON_EXPORT EngineImageSerializationProcessor
: public cc::ImageSerializationProcessor {
public:
@@ -32,11 +32,14 @@ class BLIMP_COMMON_EXPORT EngineImageSerializationProcessor
~EngineImageSerializationProcessor();
// cc::ImageSerializationProcessor implementation.
- SkPixelSerializer* GetPixelSerializer() override;
- SkPicture::InstallPixelRefProc GetPixelDeserializer() override;
+ std::unique_ptr<cc::EnginePictureCache> CreateEnginePictureCache() override;
+ std::unique_ptr<cc::ClientPictureCache> CreateClientPictureCache() override;
private:
+ // A serializer that be used to pass in to SkPicture::serialize(...) for
+ // serializing the SkPicture to a stream.
std::unique_ptr<SkPixelSerializer> pixel_serializer_;
+
mojom::BlobChannelPtr blob_channel_;
DISALLOW_COPY_AND_ASSIGN(EngineImageSerializationProcessor);

Powered by Google App Engine
This is Rietveld 408576698