Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: blimp/common/compositor/blimp_picture_cache_registry_unittest.cc

Issue 1982893002: [blimp] Add SkPicture caching support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git merge origin/master Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/compositor/blimp_picture_cache_registry_unittest.cc
diff --git a/blimp/common/compositor/blimp_picture_cache_registry_unittest.cc b/blimp/common/compositor/blimp_picture_cache_registry_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6e4671324df55454bec4fdee96d64469b1914579
--- /dev/null
+++ b/blimp/common/compositor/blimp_picture_cache_registry_unittest.cc
@@ -0,0 +1,177 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/common/compositor/blimp_picture_cache_registry.h"
+
+#include <stdint.h>
+#include <algorithm>
+#include <unordered_set>
+#include <vector>
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blimp {
+namespace {
+
+bool Contains(std::vector<uint32_t> haystack, uint32_t needle) {
Kevin M 2016/06/06 23:33:58 Your tests might benefit from EXPECT_THAT(added_,
nyquist 2016/06/10 22:02:24 Wow, that and EXPECT_TRUE(foo.empty()) was awesome
+ return std::find(haystack.begin(), haystack.end(), needle) != haystack.end();
+}
+
+class BlimpPictureCacheRegistryTest : public testing::Test {
+ protected:
+ BlimpPictureCacheRegistry registry_;
+ std::vector<uint32_t> added_;
+ std::vector<uint32_t> removed_;
+};
Kevin M 2016/06/06 23:33:58 DISALLOW yada
nyquist 2016/06/10 22:02:24 Done.
+
+TEST_F(BlimpPictureCacheRegistryTest, SingleItemCommitFlow) {
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ uint32_t item = 1;
+ registry_.IncrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item));
+ added_.clear();
+
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item));
+}
+
+TEST_F(BlimpPictureCacheRegistryTest, SingleItemMultipleTimesInSingleCommit) {
+ uint32_t item = 1;
+ registry_.IncrementRefCount(item);
+ registry_.IncrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item));
+ added_.clear();
+
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ registry_.DecrementRefCount(item);
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item));
+}
+
+TEST_F(BlimpPictureCacheRegistryTest, SingleItemMultipleTimesAcrossCommits) {
+ uint32_t item = 1;
+ registry_.IncrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item));
+ added_.clear();
+
+ registry_.IncrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item));
+}
+
+TEST_F(BlimpPictureCacheRegistryTest, SingleItemComplexInteractions) {
+ uint32_t item = 1;
+ registry_.IncrementRefCount(item);
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+
+ registry_.IncrementRefCount(item);
+ registry_.DecrementRefCount(item);
+ registry_.IncrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item));
+ added_.clear();
+
+ registry_.DecrementRefCount(item);
+ registry_.IncrementRefCount(item);
+ registry_.DecrementRefCount(item);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item));
+}
+
+TEST_F(BlimpPictureCacheRegistryTest, MultipleItems) {
+ uint32_t item1 = 1;
+ uint32_t item2 = 2;
+ uint32_t item3 = 3;
+ registry_.IncrementRefCount(item1);
+ registry_.IncrementRefCount(item2);
+ registry_.IncrementRefCount(item3);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(3U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item1));
+ EXPECT_TRUE(Contains(added_, item2));
+ EXPECT_TRUE(Contains(added_, item3));
+ added_.clear();
+
+ registry_.DecrementRefCount(item3);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item3));
+ removed_.clear();
+
+ registry_.DecrementRefCount(item2);
+ registry_.IncrementRefCount(item3);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(1U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item3));
+ EXPECT_TRUE(Contains(removed_, item2));
+ added_.clear();
+ removed_.clear();
+
+ registry_.IncrementRefCount(item2);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(1U, added_.size());
+ EXPECT_EQ(0U, removed_.size());
+ EXPECT_TRUE(Contains(added_, item2));
+ added_.clear();
+
+ registry_.DecrementRefCount(item1);
+ registry_.DecrementRefCount(item2);
+ registry_.DecrementRefCount(item3);
+ registry_.Commit(&added_, &removed_);
+ EXPECT_EQ(0U, added_.size());
+ EXPECT_EQ(3U, removed_.size());
+ EXPECT_TRUE(Contains(removed_, item1));
+ EXPECT_TRUE(Contains(removed_, item2));
+ EXPECT_TRUE(Contains(removed_, item3));
+}
+
+} // namespace
+} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698