Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: blimp/engine/renderer/blimp_engine_picture_cache.cc

Issue 1982893002: [blimp] Add SkPicture caching support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix memory leak by adding virtual destructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/engine/renderer/blimp_engine_picture_cache.h"
6
7 #include <sstream>
Kevin M 2016/06/17 17:53:37 O_o Is this needed?
nyquist 2016/06/17 21:31:43 Done.
8
9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h"
11 #include "third_party/skia/include/core/SkStream.h"
12
13 namespace blimp {
14 namespace engine {
15
16 BlimpEnginePictureCache::BlimpEnginePictureCache(
17 SkPixelSerializer* pixel_serializer)
18 : pixel_serializer_(pixel_serializer) {}
19
20 BlimpEnginePictureCache::~BlimpEnginePictureCache() = default;
21
22 void BlimpEnginePictureCache::MarkPictureForUnregistration(
23 const SkPicture* picture) {
24 DCHECK(picture);
25 reference_tracker_.DecrementRefCount(picture->uniqueID());
26 }
27
28 void BlimpEnginePictureCache::MarkPictureForRegistration(
29 const SkPicture* picture) {
30 DCHECK(picture);
31 reference_tracker_.IncrementRefCount(picture->uniqueID());
32
33 // Do not serialize multiple times, even though the item is referred to from
34 // multiple places.
35 if (CacheContainsPicture(picture)) {
36 return;
37 }
38
39 SerializePictureAndAddToCache(picture);
40 }
41
42 cc::PictureCacheUpdate BlimpEnginePictureCache::CalculateCacheUpdateAndFlush() {
43 std::vector<uint32_t> added;
44 std::vector<uint32_t> removed;
45 reference_tracker_.CommitRefCounts(&added, &removed);
46
47 // Create cache update consisting of new pictures.
48 cc::PictureCacheUpdate update;
49 for (const uint32_t item : added) {
50 auto entry = pictures_.find(item);
51 DCHECK(entry != pictures_.end());
52 update.push_back(entry->second);
53 }
54
55 // All new items will be sent to the client, so clear everything.
56 pictures_.clear();
57
58 return update;
59 }
60
61 bool BlimpEnginePictureCache::CacheContainsPicture(
62 const SkPicture* picture) const {
63 return pictures_.find(picture->uniqueID()) != pictures_.end();
64 }
65
66 void BlimpEnginePictureCache::SerializePictureAndAddToCache(
67 const SkPicture* picture) {
68 SkDynamicMemoryWStream stream;
69 picture->serialize(&stream, pixel_serializer_);
70 DCHECK_GE(stream.bytesWritten(), 0u);
71
72 // Store the picture data until it is sent to the client.
73 cc::PictureData picture_data;
74 picture_data.unique_id = picture->uniqueID();
75 picture_data.data.reset(stream.copyToData());
76 pictures_[picture_data.unique_id] = picture_data;
77 }
78
79 } // namespace engine
80 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698