[blimp] Add SkPicture caching support.

cc/playback/drawing_display_item.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/playback/drawing_display_item.h"
 
 #include <stddef.h>
 
 #include <string>
 
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/trace_event.h"
 #include "base/trace_event/trace_event_argument.h"
 #include "base/values.h"
 #include "cc/debug/picture_debug_util.h"
 #include "cc/proto/display_item.pb.h"
 #include "cc/proto/image_serialization_processor.h"
+#include "cc/proto/picture_cache.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "third_party/skia/include/core/SkData.h"
 #include "third_party/skia/include/core/SkMatrix.h"
 #include "third_party/skia/include/core/SkPicture.h"
 #include "third_party/skia/include/core/SkStream.h"
 #include "third_party/skia/include/utils/SkPictureUtils.h"
 #include "ui/gfx/skia_util.h"
 
 namespace cc {
 
 DrawingDisplayItem::DrawingDisplayItem() {}
 
 DrawingDisplayItem::DrawingDisplayItem(sk_sp<const SkPicture> picture) {
   SetNew(std::move(picture));
 }
 
 DrawingDisplayItem::DrawingDisplayItem(
     const proto::DisplayItem& proto,
-    ImageSerializationProcessor* image_serialization_processor) {
+    ClientPictureCache* client_picture_cache) {
   DCHECK_EQ(proto::DisplayItem::Type_Drawing, proto.type());
+  DCHECK(client_picture_cache);
 
-  sk_sp<SkPicture> picture;
   const proto::DrawingDisplayItem& details = proto.drawing_item();
-  if (details.has_picture()) {
-    SkMemoryStream stream(details.picture().data(), details.picture().size());
+  DCHECK(details.has_id());
+  const proto::SkPictureID& sk_picture_id = details.id();
+  DCHECK(sk_picture_id.has_unique_id());
 
-    picture = SkPicture::MakeFromStream(
-        &stream, image_serialization_processor->GetPixelDeserializer());
-  }
+  uint32_t unique_id = sk_picture_id.unique_id();
+  sk_sp<const SkPicture> picture = client_picture_cache->GetPicture(unique_id);
+  DCHECK(picture);
 
   SetNew(std::move(picture));
 }
 
 DrawingDisplayItem::DrawingDisplayItem(const DrawingDisplayItem& item) {
   item.CloneTo(this);
 }
 
 DrawingDisplayItem::~DrawingDisplayItem() {
 }
 
 void DrawingDisplayItem::SetNew(sk_sp<const SkPicture> picture) {
   picture_ = std::move(picture);
 }
 
-void DrawingDisplayItem::ToProtobuf(
-    proto::DisplayItem* proto,
-    ImageSerializationProcessor* image_serialization_processor) const {
+void DrawingDisplayItem::ToProtobuf(proto::DisplayItem* proto) const {
   TRACE_EVENT0("cc.remote", "DrawingDisplayItem::ToProtobuf");
   proto->set_type(proto::DisplayItem::Type_Drawing);
 
-  proto::DrawingDisplayItem* details = proto->mutable_drawing_item();
+  if (!picture_)
+    return;
 
-  // Just use skia's serialize() method for now.
-  if (picture_) {
-    TRACE_EVENT0("cc.remote",
-                 "DrawingDisplayItem::ToProtobuf SkPicture::Serialize");
-    SkDynamicMemoryWStream stream;
-    picture_->serialize(&stream,
-                        image_serialization_processor->GetPixelSerializer());
-    if (stream.bytesWritten() > 0) {
-      SkAutoDataUnref data(stream.copyToData());
-      details->set_picture(data->data(), data->size());
-    }
-  }
+  proto->mutable_drawing_item()->mutable_id()->set_unique_id(
+      picture_->uniqueID());
+}
+
+void DrawingDisplayItem::MarkForRegistrationEngine(
+    EnginePictureCache* engine_picture_cache) const {
+  if (picture_ && engine_picture_cache)

[vmpstr, 2016/06/16 22:09:59]

Maybe just expose picture_?

[nyquist, 2016/06/24 11:11:14]

Done.

+    engine_picture_cache->MarkPictureForRegistration(picture_.get());
+}
+
+void DrawingDisplayItem::MarkForUnregistrationEngine(
+    EnginePictureCache* engine_picture_cache) const {
+  if (picture_ && engine_picture_cache)
+    engine_picture_cache->MarkPictureForUnregistration(picture_.get());
 }
 
 void DrawingDisplayItem::Raster(SkCanvas* canvas,
                                 const gfx::Rect& canvas_target_playback_rect,
                                 SkPicture::AbortCallback* callback) const {
   // The canvas_playback_rect can be empty to signify no culling is desired.
   if (!canvas_target_playback_rect.IsEmpty()) {
     const SkMatrix& matrix = canvas->getTotalMatrix();
     const SkRect& cull_rect = picture_->cullRect();
     SkRect target_rect;
@@ skipping 42 matching lines @@
 
 size_t DrawingDisplayItem::ExternalMemoryUsage() const {
   return SkPictureUtils::ApproximateBytesUsed(picture_.get());
 }
 
 int DrawingDisplayItem::ApproximateOpCount() const {
   return picture_->approximateOpCount();
 }
 
 }  // namespace cc