Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: blimp/client/feature/compositor/blimp_client_picture_cache.cc

Issue 1982893002: [blimp] Add SkPicture caching support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from kmarshall Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/client/feature/compositor/blimp_client_picture_cache.h"
6
7 #include <utility>
8 #include <vector>
9
10 #include "third_party/skia/include/core/SkStream.h"
11
12 namespace blimp {
13 namespace client {
14
15 namespace {
Kevin M 2016/06/11 00:29:32 newline after "namespace", but remove the one befo
nyquist 2016/06/14 01:37:56 Done.
16 // Helper function to deserialize the content of |picture_data| into an
17 // SkPicture.
18 sk_sp<const SkPicture> DeserializePicture(
19 SkPicture::InstallPixelRefProc pixel_deserializer,
20 const cc::PictureData& picture_data) {
21 SkMemoryStream stream(picture_data.data);
22 return SkPicture::MakeFromStream(&stream, pixel_deserializer);
23 }
24
25 } // namespace
26
27 BlimpClientPictureCache::BlimpClientPictureCache(
28 SkPicture::InstallPixelRefProc pixel_deserializer)
29 : pixel_deserializer_(pixel_deserializer) {}
30
31 BlimpClientPictureCache::~BlimpClientPictureCache() = default;
32
33 sk_sp<const SkPicture> BlimpClientPictureCache::GetPicture(
34 uint32_t engine_picture_id) {
35 return GetPictureFromCache(engine_picture_id);
36 }
37
38 void BlimpClientPictureCache::ApplyCacheUpdate(
39 const cc::PictureCacheUpdate& cache_update) {
40 AddNewPicturesToCache(cache_update);
41 }
42
43 void BlimpClientPictureCache::Flush() {
44 // Calculate which pictures can now be removed. |added| is only used for
45 // verifying that what we calculated matches the new items that have been
46 // inserted into the cache.
47 std::vector<uint32_t> added;
48 std::vector<uint32_t> removed;
49 reference_tracker_.CommitRefCounts(&added, &removed);
50
51 #if DCHECK_IS_ON()
52 VerifyCacheUpdateMatchesReferenceTrackerData(added);
53 #endif // DCHECK_IS_ON()
54
55 RemoveUnusedPicturesFromCache(removed);
56 }
57
58 void BlimpClientPictureCache::MarkPictureForUnregistration(
59 uint32_t engine_picture_id) {
60 reference_tracker_.DecrementRefCount(engine_picture_id);
61 }
62
63 void BlimpClientPictureCache::MarkPictureForRegistration(
64 uint32_t engine_picture_id) {
65 reference_tracker_.IncrementRefCount(engine_picture_id);
66 }
67
68 void BlimpClientPictureCache::AddNewPicturesToCache(
69 const cc::PictureCacheUpdate& cache_update) {
70 for (const cc::PictureData& picture_data : cache_update) {
71 sk_sp<const SkPicture> deserialized_picture =
72 DeserializePicture(pixel_deserializer_, picture_data);
73 DCHECK(pictures_.find(picture_data.unique_id) == pictures_.end());
74
75 pictures_[picture_data.unique_id] = std::move(deserialized_picture);
76
77 #if DCHECK_IS_ON()
78 last_added_.insert(picture_data.unique_id);
79 #endif // DCHECK_IS_ON()
80 }
81 }
82
83 void BlimpClientPictureCache::RemoveUnusedPicturesFromCache(
84 const std::vector<uint32_t>& removed) {
85 for (const auto& it : removed) {
86 auto entry = pictures_.find(it);
87 DCHECK(entry != pictures_.end());
88 pictures_.erase(entry);
89 }
90 }
91
92 sk_sp<const SkPicture> BlimpClientPictureCache::GetPictureFromCache(
93 uint32_t engine_picture_id) {
94 DCHECK(pictures_.find(engine_picture_id) != pictures_.end());
95 return pictures_[engine_picture_id];
96 }
97
98 #if DCHECK_IS_ON()
99 void BlimpClientPictureCache::VerifyCacheUpdateMatchesReferenceTrackerData(
100 const std::vector<uint32_t>& new_tracked_items) {
101 DCHECK_EQ(new_tracked_items.size(), last_added_.size());
102 DCHECK(std::unordered_set<uint32_t>(new_tracked_items.begin(),
103 new_tracked_items.end()) == last_added_);
104 last_added_.clear();
105 }
106 #endif // DCHECK_IS_ON()
107
108 } // namespace client
109 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698