Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1982883002: Use StringPiece in cups_helper.cc. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
skau, dpapad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringPiece in cups_helper.cc. - Also use C++11-isms when appropriate. - And remove printing:: prefix in namespace printing. Committed: https://crrev.com/d24bc535daa47eb6af03528178fdc7c48f9c73cd Cr-Commit-Position: refs/heads/master@{#394229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -104 lines) Patch
M printing/backend/cups_helper.h View 2 chunks +3 lines, -4 lines 0 comments Download
M printing/backend/cups_helper.cc View 20 chunks +76 lines, -76 lines 0 comments Download
M printing/backend/cups_helper_unittest.cc View 12 chunks +18 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Lei Zhang
Hope this does not step on your toes too much. If you want to get ...
4 years, 7 months ago (2016-05-17 01:02:19 UTC) #3
skau
I'm happy to do the merge. LGTM.
4 years, 7 months ago (2016-05-17 20:17:59 UTC) #4
Lei Zhang
+dpapad because I still need a committer to review.
4 years, 7 months ago (2016-05-17 20:33:31 UTC) #6
dpapad
lgtm
4 years, 7 months ago (2016-05-17 20:52:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982883002/1
4 years, 7 months ago (2016-05-17 20:59:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 21:07:21 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 21:08:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d24bc535daa47eb6af03528178fdc7c48f9c73cd
Cr-Commit-Position: refs/heads/master@{#394229}

Powered by Google App Engine
This is Rietveld 408576698