Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1982853002: Allow the SDK to be set via a summary file (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow the SDK to be set via a summary file The generated summary file matches the generated DDC sdk - i.e., it does not include dart:io. I modified the codegen_tests to the summary and had to prune the parts of unittest that relied on dart:io. Paul / Konstantin: can one of you please look at the summary part? Bob: can you please look at the unittest changes? R=rnystrom@google.com, scheglov@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d785be9ae644bf68c359eb8a7a89756dd73196d1

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -24 lines) Patch
A lib/runtime/dart_sdk.sum View Binary file 0 comments Download
M lib/src/analyzer/context.dart View 6 chunks +19 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_test.dart View 1 4 chunks +37 lines, -14 lines 0 comments Download
M tool/build_sdk.dart View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vsm
4 years, 7 months ago (2016-05-16 23:42:11 UTC) #3
vsm
On 2016/05/16 23:42:11, vsm wrote: Hmm, perhaps I should delete dart_sdk .sum from here. The ...
4 years, 7 months ago (2016-05-16 23:43:21 UTC) #4
scheglov
LGTM
4 years, 7 months ago (2016-05-16 23:49:43 UTC) #5
Bob Nystrom
Couple of nits then unittest stuff LGTM! https://codereview.chromium.org/1982853002/diff/1/test/codegen_test.dart File test/codegen_test.dart (right): https://codereview.chromium.org/1982853002/diff/1/test/codegen_test.dart#newcode222 test/codegen_test.dart:222: packageFiles.forEach((f) { ...
4 years, 7 months ago (2016-05-16 23:59:40 UTC) #6
vsm
https://codereview.chromium.org/1982853002/diff/1/test/codegen_test.dart File test/codegen_test.dart (right): https://codereview.chromium.org/1982853002/diff/1/test/codegen_test.dart#newcode222 test/codegen_test.dart:222: packageFiles.forEach((f) { On 2016/05/16 23:59:39, Bob Nystrom wrote: > ...
4 years, 7 months ago (2016-05-17 00:06:38 UTC) #7
vsm
4 years, 7 months ago (2016-05-17 00:10:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d785be9ae644bf68c359eb8a7a89756dd73196d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698