Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 198283003: android: Remove three unnecessary md5sum calls. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

android: Remove three unnecessary md5sum calls. After r256667, the list of java files for javac is written into a gyp filelist, which gets rewritten if a java file is removed. (If a generated java file is removed, that still doesn't cause a rebuild, but that didn't happen before this CL either, http://crbug.com/) This allows removing the md5sum call for javac in java_apk.gypi. java.gypi also has additional_input_paths as input, but that's only used for stamp files, for ordering purposes, so it's not necessary to re-run the javac action if a stamp file disappears from additional_input_paths. With the same reasoning, the md5sum call in 'ant package resources' is not needed: additional_input_paths is the only non-stamp input that isn't also on the command line. ('ant package resources' is missing some inputs, but that's independent of this change: http://crbug.com/351928) No behavior change. BUG=177552 R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M build/java.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 6 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 9 months ago (2014-03-12 23:03:04 UTC) #1
cjhopman
lgtm
6 years, 9 months ago (2014-03-13 01:05:40 UTC) #2
Nico
6 years, 9 months ago (2014-03-13 04:48:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r256746 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698