chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

index 8b7da808841024b43f43ddd6b3ef2364709bea15..78c1a27907ed3b7de61e5725cc2bf89565b9bd03 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java

@@ -10,6 +10,7 @@ import android.view.View.OnClickListener;

import android.view.ViewGroup;

import org.chromium.base.VisibleForTesting;

+import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.browser.device.DeviceClassManager;

/**

@@ -105,6 +106,8 @@ public class SnackbarManager implements OnClickListener {

public void showSnackbar(Snackbar snackbar) {

if (!mActivityInForeground || mIsDisabledForTesting) return;

+ RecordHistogram.recordSparseSlowlyHistogram("Snackbar.Shown", snackbar.getIdentifier());

mSnackbars.add(snackbar);

updateView();

mView.announceforAccessibility();