chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUndoController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

index 16fd04118887ad795bc87c7c25fd34a8a6b79a73..b00d830ab891c98a6824b2cddd11fbd4e9bb896c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

@@ -83,7 +83,8 @@ public class BookmarkUtils {

@Override

public void onAction(Object actionData) { }

- }, Snackbar.TYPE_NOTIFICATION).setSingleLine(false);

+ }, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_BOOKMARK_ADDED)

+ .setSingleLine(false);

RecordUserAction.record("EnhancedBookmarks.AddingFailed");

} else {

String folderName = bookmarkModel.getBookmarkTitle(

@@ -92,13 +93,14 @@ public class BookmarkUtils {

createSnackbarControllerForEditButton(activity, bookmarkId);

if (getLastUsedParent(activity) == null) {

snackbar = Snackbar.make(activity.getString(R.string.bookmark_page_saved),

- snackbarController, Snackbar.TYPE_ACTION);

+ snackbarController, Snackbar.TYPE_ACTION, Snackbar.UMA_BOOKMARK_ADDED);

} else {

- snackbar = Snackbar.make(folderName, snackbarController, Snackbar.TYPE_ACTION)

+ snackbar = Snackbar.make(folderName, snackbarController, Snackbar.TYPE_ACTION,

+ Snackbar.UMA_BOOKMARK_ADDED)

.setTemplateText(activity.getString(R.string.bookmark_page_saved_folder));

}

- snackbar.setSingleLine(false).setAction(

- activity.getString(R.string.bookmark_item_edit), null);

+ snackbar.setSingleLine(false).setAction(activity.getString(R.string.bookmark_item_edit),

+ null);

}

snackbarManager.showSnackbar(snackbar);