Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19828007: Hide knowledge of webkit::ppapi::Plugin from chrome. This is part of moving ppapi implementation fr… (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
bbudge, brettw
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, raymes+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Hide knowledge of webkit::ppapi::Plugin from chrome. This is part of moving ppapi implementation from webkit/plugins/ppapi to content/renderer. BUG=263054 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213350

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -220 lines) Patch
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_drm_renderer_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 9 chunks +18 lines, -36 lines 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 3 chunks +7 lines, -15 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M ppapi/api/private/ppb_instance_private.idl View 1 chunk +17 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 2 4 chunks +22 lines, -35 lines 0 comments Download
M ppapi/c/private/ppb_instance_private.h View 2 chunks +24 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 6 chunks +15 lines, -28 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_entry_points.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 4 chunks +19 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 1 2 2 chunks +10 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 5 chunks +20 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 6 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
7 years, 5 months ago (2013-07-23 21:12:24 UTC) #1
bbudge
Lots of nice cleanup. Thanks for working on this. Some comments need to be updated ...
7 years, 5 months ago (2013-07-23 23:59:58 UTC) #2
jam
https://codereview.chromium.org/19828007/diff/19001/ppapi/api/private/ppb_nacl_private.idl File ppapi/api/private/ppb_nacl_private.idl (right): https://codereview.chromium.org/19828007/diff/19001/ppapi/api/private/ppb_nacl_private.idl#newcode25 ppapi/api/private/ppb_nacl_private.idl:25: /* Launches NaCl's sel_ldr process. Returns PP_NACL_OK on success ...
7 years, 5 months ago (2013-07-24 05:07:39 UTC) #3
jam
TBR=brettw for the trivial enum movement in src\ppapi
7 years, 5 months ago (2013-07-24 05:13:45 UTC) #4
brettw
7 years, 5 months ago (2013-07-24 05:51:47 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698