Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1982683002: Disable MediaCodecBrdigeTest on unsupported devices (Closed)

Created:
4 years, 7 months ago by kraush
Modified:
4 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MediaCodecBrdigeTest on unsupported devices SdkMediaCodecBridgeTest.PresentationTimestampsDoNotDecrease uses VP8 and will thus currently crash on devices where VP8 is not supported. This change disables the test on those devices. BUG=611578 Committed: https://crrev.com/b602d01299d28da09ba960ad0a4292e2bbe97f48 Cr-Commit-Position: refs/heads/master@{#394150}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary skip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/android/sdk_media_codec_bridge_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kraush
Hi qinmin, Seems I missed one of the tests that uses VP8 last week. Can ...
4 years, 7 months ago (2016-05-16 16:16:32 UTC) #2
qinmin
lgtm% nit https://codereview.chromium.org/1982683002/diff/1/media/base/android/sdk_media_codec_bridge_unittest.cc File media/base/android/sdk_media_codec_bridge_unittest.cc (left): https://codereview.chromium.org/1982683002/diff/1/media/base/android/sdk_media_codec_bridge_unittest.cc#oldcode275 media/base/android/sdk_media_codec_bridge_unittest.cc:275: SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE(); nit: remove this?
4 years, 7 months ago (2016-05-16 18:22:13 UTC) #3
kraush
https://codereview.chromium.org/1982683002/diff/1/media/base/android/sdk_media_codec_bridge_unittest.cc File media/base/android/sdk_media_codec_bridge_unittest.cc (left): https://codereview.chromium.org/1982683002/diff/1/media/base/android/sdk_media_codec_bridge_unittest.cc#oldcode275 media/base/android/sdk_media_codec_bridge_unittest.cc:275: SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE(); On 2016/05/16 18:22:13, qinmin wrote: > nit: remove ...
4 years, 7 months ago (2016-05-17 14:49:18 UTC) #4
kraush
Removed the unnecessary skip as suggested. I'll be committing this revision. Thanks for the fast ...
4 years, 7 months ago (2016-05-17 14:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982683002/20001
4 years, 7 months ago (2016-05-17 14:53:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 17:01:17 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:04:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b602d01299d28da09ba960ad0a4292e2bbe97f48
Cr-Commit-Position: refs/heads/master@{#394150}

Powered by Google App Engine
This is Rietveld 408576698