Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: third_party/webrtc_overrides/webrtc/base/logging.h

Issue 1982643002: Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More comments and a new case(LS_NONE) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/webrtc_overrides/webrtc/base/logging.h
diff --git a/third_party/webrtc_overrides/webrtc/base/logging.h b/third_party/webrtc_overrides/webrtc/base/logging.h
index e9ca47e03269f6384586394fcc71f68fd76636ce..67893926d5a71f7af25381cdc2f77dcdf29c8014 100644
--- a/third_party/webrtc_overrides/webrtc/base/logging.h
+++ b/third_party/webrtc_overrides/webrtc/base/logging.h
@@ -26,6 +26,15 @@
#include "third_party/webrtc_overrides/webrtc/base/diagnostic_logging.h"
+// If WebRTC code is built inside Chromium but run standalone,
+// Chromium logging will be used but not initialised. This is usually
+// OK, but in certain cases we do want that initialisation, so we
+// expose it here. For example, you must call this if you want to
+// decrease the log level below -1, as done by the libfuzzer fuzzers.
+namespace rtc {
+ void InitChromiumLoggingAndCommandLine();
tommi (sloooow) - chröme 2016/05/18 11:47:50 nit: we don't indent contents of namespaces.
+}
tommi (sloooow) - chröme 2016/05/18 11:47:50 nit: } // namespace rtc
+
//////////////////////////////////////////////////////////////////////
// WebRTC macros which in DiagnosticLogMessage are mapped over to
// their VLOG equivalent in base/logging.h.

Powered by Google App Engine
This is Rietveld 408576698