Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/webrtc_overrides/webrtc/base/logging.h

Issue 1982643002: Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ...and expose it even if !defined(LOGGING_INSIDE_WEBRTC) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/webrtc_overrides/webrtc/base/logging.h
diff --git a/third_party/webrtc_overrides/webrtc/base/logging.h b/third_party/webrtc_overrides/webrtc/base/logging.h
index e9ca47e03269f6384586394fcc71f68fd76636ce..b3b3fc8ab57840f0ae90e3e6d9b353b27791c64c 100644
--- a/third_party/webrtc_overrides/webrtc/base/logging.h
+++ b/third_party/webrtc_overrides/webrtc/base/logging.h
@@ -26,6 +26,13 @@
#include "third_party/webrtc_overrides/webrtc/base/diagnostic_logging.h"
+// Chromium allows a minimum programmatically-set log level of -1
Henrik Grunell 2016/05/18 08:43:26 Explain that this function is only used when WebRT
katrielc 2016/05/18 09:06:42 I checked with phoglund@ and they don't plan to mo
Henrik Grunell 2016/05/18 09:29:32 Acknowledged.
+// unless there is a command line set up with --v=x. This exposes
+// those initialisation calls to WebRTC code.
+namespace rtc {
+ void InitChromiumLoggingAndCommandLine();
+}
+
//////////////////////////////////////////////////////////////////////
// WebRTC macros which in DiagnosticLogMessage are mapped over to
// their VLOG equivalent in base/logging.h.

Powered by Google App Engine
This is Rietveld 408576698