[Autofill] Sort profiles and credit cards by frecency in PaymentRequest.

chrome/browser/autofill/android/personal_data_manager_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_ANDROID_PERSONAL_DATA_MANAGER_ANDROID_H_
 #define CHROME_BROWSER_AUTOFILL_ANDROID_PERSONAL_DATA_MANAGER_ANDROID_H_
 
 #include "base/android/jni_weak_ref.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/personal_data_manager_observer.h"
 
 namespace autofill {
 
 // Android wrapper of the PersonalDataManager which provides access from the
 // Java layer. Note that on Android, there's only a single profile, and
 // therefore a single instance of this wrapper.
 class PersonalDataManagerAndroid : public PersonalDataManagerObserver {
  public:
   PersonalDataManagerAndroid(JNIEnv* env, jobject obj);
 
   // These functions act on "web profiles" aka "LOCAL_PROFILE" profiles.
   // -------------------------
 
   // Returns the number of web and auxiliary profiles.
   jint GetProfileCount(JNIEnv* unused_env,
                        const base::android::JavaParamRef<jobject>& unused_obj);
 
-  // Returns the profile as indexed by |index| in the PersonalDataManager's
-  // |GetProfiles()| collection.
-  base::android::ScopedJavaLocalRef<jobject> GetProfileByIndex(
+  // Returns the GUIDs of the profiles that should be suggested to the user. The
+  // profiles are already sorted by frecency.
+  base::android::ScopedJavaLocalRef<jobjectArray> GetProfileGUIDsToSuggest(
       JNIEnv* env,
-      const base::android::JavaParamRef<jobject>& unused_obj,
-      jint index);
+      const base::android::JavaParamRef<jobject>& unused_obj);
 
   // Returns the profile with the specified |jguid|, or NULL if there is no
   // profile with the specified |jguid|. Both web and auxiliary profiles may
   // be returned.
   base::android::ScopedJavaLocalRef<jobject> GetProfileByGUID(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& unused_obj,
       const base::android::JavaParamRef<jstring>& jguid);
 
   // Adds or modifies a profile.  If |jguid| is an empty string, we are creating
@@ skipping 17 matching lines @@
       bool address_only);
 
   // These functions act on local credit cards.
   // --------------------
 
   // Returns the number of credit cards.
   jint GetCreditCardCount(
       JNIEnv* unused_env,
       const base::android::JavaParamRef<jobject>& unused_obj);
 
-  // Returns the credit card as indexed by |index| in the PersonalDataManager's
-  // |GetCreditCards()| collection.
-  base::android::ScopedJavaLocalRef<jobject> GetCreditCardByIndex(
+  // Returns the GUIDs of the credit cards that should be suggested to the
+  // user. The cards are already deduped and sorted by frecency with the

[Mathieu, 2016/05/20 13:57:08]

nit: I wouldn't make implementation specific comments in case it ever changes.
Here you can say that the suggestions are processed and ready to be shown to the
user (and perhaps "see X class for details")

[sebsg, 2016/05/24 17:27:32]

Good point.

+  // expired cards last.
+  base::android::ScopedJavaLocalRef<jobjectArray> GetCreditCardGUIDsToSuggest(
       JNIEnv* env,
-      const base::android::JavaParamRef<jobject>& unused_obj,
-      jint index);
+      const base::android::JavaParamRef<jobject>& unused_ob);
 
   // Returns the credit card with the specified |jguid|, or NULL if there is
   // no credit card with the specified |jguid|.
   base::android::ScopedJavaLocalRef<jobject> GetCreditCardByGUID(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& unused_obj,
       const base::android::JavaParamRef<jstring>& jguid);
 
   // Adds or modifies a credit card.  If |jguid| is an empty string, we are
   // creating a new profile.  Else we are updating an existing profile.  Always
@@ skipping 21 matching lines @@
       const base::android::JavaParamRef<jobject>& jweb_contents,
       const base::android::JavaParamRef<jstring>& jguid,
       const base::android::JavaParamRef<jobject>& jdelegate);
 
   // PersonalDataManagerObserver:
   void OnPersonalDataChanged() override;
 
   // Registers the JNI bindings for this class.
   static bool Register(JNIEnv* env);
 
+  // Sets the use count and use date of the profile associated to the |jguid|.
+  void SetProfileUseStatsForTest(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& unused_obj,
+      const base::android::JavaParamRef<jstring>& jguid,
+      jint count,
+      jint date);
+
+  // Sets the use count and use date of the credit card associated to the
+  // |jguid|.
+  void SetCreditCardUseStatsForTest(
+      JNIEnv* env,
+      const base::android::JavaParamRef<jobject>& unused_obj,
+      const base::android::JavaParamRef<jstring>& jguid,
+      jint count,
+      jint date);
+
  private:
   ~PersonalDataManagerAndroid() override;
 
   // Pointer to the java counterpart.
   JavaObjectWeakGlobalRef weak_java_obj_;
 
   // Pointer to the PersonalDataManager for the main profile.
   PersonalDataManager* personal_data_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(PersonalDataManagerAndroid);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_AUTOFILL_ANDROID_PERSONAL_DATA_MANAGER_ANDROID_H_