[Autofill] Sort profiles and credit cards by frecency in PaymentRequest.

chrome/browser/autofill/android/personal_data_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/android/personal_data_manager_android.h"
 
 #include <stddef.h>
+#include <algorithm>
 #include <memory>
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "chrome/browser/android/resource_mapper.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/pref_names.h"
 #include "components/autofill/content/browser/content_autofill_driver.h"
 #include "components/autofill/content/browser/content_autofill_driver_factory.h"
 #include "components/autofill/core/browser/autofill_country.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 253 matching lines @@
     : weak_java_obj_(env, obj),
       personal_data_manager_(PersonalDataManagerFactory::GetForProfile(
           ProfileManager::GetActiveUserProfile())) {
   personal_data_manager_->AddObserver(this);
 }
 
 PersonalDataManagerAndroid::~PersonalDataManagerAndroid() {
   personal_data_manager_->RemoveObserver(this);
 }
 
 jint PersonalDataManagerAndroid::GetProfileCount(

[Mathieu, 2016/05/20 13:57:08]

Looks like this function can be removed?

If not, we should probably work to remove it. It has high complexity just to
return a count.

[sebsg, 2016/05/24 17:27:32]

Done.

     JNIEnv* unused_env,
     const JavaParamRef<jobject>& unused_obj) {
-  return personal_data_manager_->GetProfiles().size();
+  return personal_data_manager_->GetProfilesToSuggest().size();
 }
 
-ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetProfileByIndex(
+ScopedJavaLocalRef<jobjectArray>
+PersonalDataManagerAndroid::GetProfileGUIDsToSuggest(
     JNIEnv* env,
-    const JavaParamRef<jobject>& unused_obj,
-    jint index) {
-  const std::vector<AutofillProfile*>& profiles =
-      personal_data_manager_->GetProfiles();
-  size_t index_size_t = static_cast<size_t>(index);
-  DCHECK_LT(index_size_t, profiles.size());
-  return CreateJavaProfileFromNative(env, *profiles[index_size_t]);
+    const JavaParamRef<jobject>& unused_obj) {
+  std::vector<AutofillProfile*> profiles =
+      personal_data_manager_->GetProfilesToSuggest();
+
+  std::vector<base::string16> guids;
+
+  for (AutofillProfile* profile : profiles) {

[Mathieu, 2016/05/20 13:57:08]

nit: no need for braces here and below

[sebsg, 2016/05/24 17:27:32]

Done.

+    guids.push_back(base::UTF8ToUTF16(profile->guid()));
+  }
+
+  return base::android::ToJavaArrayOfStrings(env, guids);
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetProfileByGUID(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
     const JavaParamRef<jstring>& jguid) {
   AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
       ConvertJavaStringToUTF8(env, jguid));
   if (!profile)
     return ScopedJavaLocalRef<jobject>();
@@ skipping 37 matching lines @@
     suggested_fields->push_back(ADDRESS_HOME_CITY);
     suggested_fields->push_back(ADDRESS_HOME_STATE);
     suggested_fields->push_back(ADDRESS_HOME_ZIP);
     suggested_fields->push_back(ADDRESS_HOME_SORTING_CODE);
     suggested_fields->push_back(ADDRESS_HOME_COUNTRY);
     minimal_fields_shown = suggested_fields->size();
   }
 
   std::vector<base::string16> labels;
   AutofillProfile::CreateInferredLabels(
-      personal_data_manager_->GetProfiles(), suggested_fields.get(), NAME_FULL,
-      minimal_fields_shown, g_browser_process->GetApplicationLocale(), &labels);
+      personal_data_manager_->GetProfilesToSuggest(), suggested_fields.get(),
+      NAME_FULL, minimal_fields_shown,
+      g_browser_process->GetApplicationLocale(), &labels);
 
   return base::android::ToJavaArrayOfStrings(env, labels);
 }
 
 jint PersonalDataManagerAndroid::GetCreditCardCount(
     JNIEnv* unused_env,
     const JavaParamRef<jobject>& unused_obj) {
-  return personal_data_manager_->GetCreditCards().size();
+  return personal_data_manager_->GetCreditCardsToSuggest().size();
 }
 
-ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByIndex(
+base::android::ScopedJavaLocalRef<jobjectArray>
+PersonalDataManagerAndroid::GetCreditCardGUIDsToSuggest(
     JNIEnv* env,
-    const JavaParamRef<jobject>& unused_obj,
-    jint index) {
-  const std::vector<CreditCard*>& credit_cards =
-      personal_data_manager_->GetCreditCards();
-  size_t index_size_t = static_cast<size_t>(index);
-  DCHECK_LT(index_size_t, credit_cards.size());
-  return CreateJavaCreditCardFromNative(env, *credit_cards[index_size_t]);
+    const base::android::JavaParamRef<jobject>& unused_ob) {
+  std::vector<CreditCard*> credit_cards =
+      personal_data_manager_->GetCreditCardsToSuggest();
+
+  std::vector<base::string16> guids;
+  for (CreditCard* credit_card : credit_cards) {
+    guids.push_back(base::UTF8ToUTF16(credit_card->guid()));
+  }
+
+  return base::android::ToJavaArrayOfStrings(env, guids);
 }
 
 ScopedJavaLocalRef<jobject> PersonalDataManagerAndroid::GetCreditCardByGUID(
     JNIEnv* env,
     const JavaParamRef<jobject>& unused_obj,
     const JavaParamRef<jstring>& jguid) {
   CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
           ConvertJavaStringToUTF8(env, jguid));
   if (!card)
     return ScopedJavaLocalRef<jobject>();
@@ skipping 56 matching lines @@
 
   Java_PersonalDataManager_personalDataChanged(env,
                                                weak_java_obj_.get(env).obj());
 }
 
 // static
 bool PersonalDataManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
+void PersonalDataManagerAndroid::SetProfileUseStatsForTest(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid,
+    jint count,
+    jint date) {
+  AutofillProfile* profile = personal_data_manager_->GetProfileByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!profile)
+    return;
+
+  size_t count_size_t = static_cast<size_t>(count);
+  profile->set_use_count(count_size_t);
+
+  profile->set_use_date(base::Time::FromTimeT(date));
+}
+
+void PersonalDataManagerAndroid::SetCreditCardUseStatsForTest(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& unused_obj,
+    const JavaParamRef<jstring>& jguid,
+    jint count,
+    jint date) {
+  CreditCard* card = personal_data_manager_->GetCreditCardByGUID(
+      ConvertJavaStringToUTF8(env, jguid));
+  if (!card)
+    return;
+
+  size_t count_size_t = static_cast<size_t>(count);
+  card->set_use_count(count_size_t);
+
+  card->set_use_date(base::Time::FromTimeT(date));
+}
+
 // Returns whether the Autofill feature is enabled.
 static jboolean IsAutofillEnabled(JNIEnv* env,
                                   const JavaParamRef<jclass>& clazz) {
   return GetPrefs()->GetBoolean(autofill::prefs::kAutofillEnabled);
 }
 
 // Enables or disables the Autofill feature.
 static void SetAutofillEnabled(JNIEnv* env,
                                const JavaParamRef<jclass>& clazz,
                                jboolean enable) {
@@ skipping 31 matching lines @@
                base::android::ConvertJavaStringToUTF16(env, jcountry_name)));
 }
 
 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   PersonalDataManagerAndroid* personal_data_manager_android =
       new PersonalDataManagerAndroid(env, obj);
   return reinterpret_cast<intptr_t>(personal_data_manager_android);
 }
 
 }  // namespace autofill