runtime/vm/stub_code_arm.cc - Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_arm.cc

diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc

index 8e85852851d1c2be261e31e827fa002ed8c1adfe..e4e32ce34fb0a25a5c37f4b25eb7c8a597b71808 100644

--- a/runtime/vm/stub_code_arm.cc

+++ b/runtime/vm/stub_code_arm.cc

@@ -772,9 +772,9 @@ void StubCode::GenerateInvokeDartCodeStub(Assembler* assembler) {

// kExitLinkSlotFromEntryFp must be kept in sync with the code below.

__ Push(R4);

-#if defined(TARGET_OS_MAC)

+#if defined(TARGET_ABI_IOS)

ASSERT(kExitLinkSlotFromEntryFp == -26);

-#else

+#elif defined(TARGET_ABI_EABI)

ASSERT(kExitLinkSlotFromEntryFp == -27);

#endif

__ Push(R9);

« no previous file with comments | « runtime/vm/stack_frame_arm.h ('k') | no next file » | no next file with comments »