runtime/vm/stack_frame_arm.h - Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stack_frame_arm.h

Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stack_frame_arm.h

diff --git a/runtime/vm/stack_frame_arm.h b/runtime/vm/stack_frame_arm.h

index ca89fb5726509a52b108a9bf6704a6df3281e416..a966a29b49783d8866557b03b9d7917afe818381 100644

--- a/runtime/vm/stack_frame_arm.h

+++ b/runtime/vm/stack_frame_arm.h

@@ -43,14 +43,16 @@ static const int kParamEndSlotFromFp = 1; // One slot past last parameter.

static const int kCallerSpSlotFromFp = 2;

// Entry and exit frame layout.

-#if defined(TARGET_OS_MAC)

+#if defined(TARGET_ABI_IOS)

static const int kExitLinkSlotFromEntryFp = -26;

COMPILE_ASSERT(kAbiPreservedCpuRegCount == 6);

COMPILE_ASSERT(kAbiPreservedFpuRegCount == 4);

-#else

+#elif defined(TARGET_ABI_EABI)

static const int kExitLinkSlotFromEntryFp = -27;

COMPILE_ASSERT(kAbiPreservedCpuRegCount == 7);

COMPILE_ASSERT(kAbiPreservedFpuRegCount == 4);

+#else

+#error Unknown ABI

#endif

} // namespace dart

« no previous file with comments | « runtime/vm/simulator_arm.cc ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »