runtime/vm/os_android.cc - Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/os_android.cc

Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/os_android.cc

diff --git a/runtime/vm/os_android.cc b/runtime/vm/os_android.cc

index 1c22b7c0f0a3f921bac585d8d35872f14010b2a9..045b52787808b790c2eeca324270c0219fdd3a0e 100644

--- a/runtime/vm/os_android.cc

+++ b/runtime/vm/os_android.cc

@@ -220,12 +220,12 @@ intptr_t OS::ActivationFrameAlignment() {

intptr_t OS::PreferredCodeAlignment() {

-#if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64) || \

- defined(TARGET_ARCH_ARM64)

- const int kMinimumAlignment = 16;

-#elif defined(TARGET_ARCH_ARM)

- const int kMinimumAlignment = 16;

-#elif defined(TARGET_ARCH_DBC)

+#if defined(TARGET_ARCH_IA32) || \

+ defined(TARGET_ARCH_X64) || \

+ defined(TARGET_ARCH_ARM64) || \

+ defined(TARGET_ARCH_DBC)

+ const int kMinimumAlignment = 32;

+#elif defined(TARGET_ARCH_ARM) || defined(TARGET_ARCH_MIPS)

const int kMinimumAlignment = 16;

#else

#error Unsupported architecture.

« no previous file with comments | « runtime/vm/disassembler_arm.cc ('k') | runtime/vm/os_macos.cc » ('j') | no next file with comments »