Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: runtime/vm/dart.cc

Issue 1982613003: Don't assume we want the iOS ABI if running simarm on Mac and the EABI otherwise. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/constants_arm.h ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h" 8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 9 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 #endif 610 #endif
611 611
612 if (Snapshot::IncludesCode(kind)) { 612 if (Snapshot::IncludesCode(kind)) {
613 // Checked mode affects deopt ids. 613 // Checked mode affects deopt ids.
614 buffer.AddString(FLAG_enable_asserts ? " asserts" : " no-asserts"); 614 buffer.AddString(FLAG_enable_asserts ? " asserts" : " no-asserts");
615 buffer.AddString(FLAG_enable_type_checks ? " type-checks" 615 buffer.AddString(FLAG_enable_type_checks ? " type-checks"
616 : " no-type-checks"); 616 : " no-type-checks");
617 617
618 // Generated code must match the host architecture and ABI. 618 // Generated code must match the host architecture and ABI.
619 #if defined(TARGET_ARCH_ARM) 619 #if defined(TARGET_ARCH_ARM)
620 #if defined(TARGET_OS_MACOS) 620 #if defined(TARGET_ABI_IOS)
621 buffer.AddString(" arm-ios"); 621 buffer.AddString(" arm-ios");
622 #elif defined(TARGET_ABI_EABI)
623 buffer.AddString(" arm-eabi");
622 #else 624 #else
623 buffer.AddString(" arm-eabi"); 625 #error Unknown ABI
624 #endif 626 #endif
625 buffer.AddString(TargetCPUFeatures::hardfp_supported() ? " hardfp" 627 buffer.AddString(TargetCPUFeatures::hardfp_supported() ? " hardfp"
626 : " softfp"); 628 : " softfp");
627 #elif defined(TARGET_ARCH_ARM64) 629 #elif defined(TARGET_ARCH_ARM64)
628 buffer.AddString(" arm64"); 630 buffer.AddString(" arm64");
629 #elif defined(TARGET_ARCH_MIPS) 631 #elif defined(TARGET_ARCH_MIPS)
630 buffer.AddString(" mips"); 632 buffer.AddString(" mips");
631 #elif defined(TARGET_ARCH_IA32) 633 #elif defined(TARGET_ARCH_IA32)
632 buffer.AddString(" ia32"); 634 buffer.AddString(" ia32");
633 #elif defined(TARGET_ARCH_X64) 635 #elif defined(TARGET_ARCH_X64)
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 return predefined_handles_->handles_.IsValidScopedHandle(address); 704 return predefined_handles_->handles_.IsValidScopedHandle(address);
703 } 705 }
704 706
705 707
706 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 708 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
707 ASSERT(predefined_handles_ != NULL); 709 ASSERT(predefined_handles_ != NULL);
708 return predefined_handles_->api_handles_.IsValidHandle(handle); 710 return predefined_handles_->api_handles_.IsValidHandle(handle);
709 } 711 }
710 712
711 } // namespace dart 713 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/constants_arm.h ('k') | runtime/vm/disassembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698