Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1982613002: Remove Windows Vista/XP specific code from net/dns. (Closed)

Created:
4 years, 7 months ago by martijnc
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Windows Vista/XP specific code from net/dns. BUG=580691 Committed: https://crrev.com/f1b34e7148eab5dc3819f3da0ee173d056bebcc3 Cr-Commit-Position: refs/heads/master@{#394087}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M net/dns/address_sorter_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_service_win.cc View 2 chunks +1 line, -7 lines 0 comments Download
M net/dns/dns_config_service_win_unittest.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 7 months ago (2016-05-16 16:42:52 UTC) #5
mmenke
On 2016/05/16 16:42:52, martijnc wrote: > Hi, can you review this patch? Thanks! LGTM!
4 years, 7 months ago (2016-05-16 19:32:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982613002/40001
4 years, 7 months ago (2016-05-17 07:51:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 7 months ago (2016-05-17 09:18:10 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 09:19:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1b34e7148eab5dc3819f3da0ee173d056bebcc3
Cr-Commit-Position: refs/heads/master@{#394087}

Powered by Google App Engine
This is Rietveld 408576698