add --csv parameter to skpdiff to dump all scores in a csv file. We can run it with all skps, and h…

Add --csv parameter to skpdiff to dump all scores in a csv file. We can run it with all skps, and have scores available to look at worst offenders progarmatically.

R=djsollen@google.com, zachr@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10234

[Zach Reizner, 2013-07-19 18:35:08]

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/SkDiffCo...
File experimental/skpdiff/SkDiffContext.cpp (right):

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/SkDiffCo...
experimental/skpdiff/SkDiffContext.cpp:74: FILE* csvFile = NULL;
Output of CSV should be done in a similar manner as outputting JSON. It should
be a method of SkDiffContext similar to SkDiffContext::outputRecords which takes
a SkWStream. Handling of flags should all be kept in one place in the
skpdiff_main.cpp.

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/main.cpp
File experimental/skpdiff/main.cpp (right):

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/main.cpp...
experimental/skpdiff/main.cpp:173: if (!FLAGS_csv.isEmpty()) {
Move output handling to the area below "if (!FLAGS_output.isEmpty())"

[edisonn, 2013-07-19 20:27:23]

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/SkDiffCo...
File experimental/skpdiff/SkDiffContext.cpp (right):

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/SkDiffCo...
experimental/skpdiff/SkDiffContext.cpp:74: FILE* csvFile = NULL;
On 2013/07/19 18:35:08, Zach Reizner wrote:
> Output of CSV should be done in a similar manner as outputting JSON. It should
> be a method of SkDiffContext similar to SkDiffContext::outputRecords which
takes
> a SkWStream. Handling of flags should all be kept in one place in the
> skpdiff_main.cpp.

Done.

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/main.cpp
File experimental/skpdiff/main.cpp (right):

https://codereview.chromium.org/19826002/diff/1/experimental/skpdiff/main.cpp...
experimental/skpdiff/main.cpp:173: if (!FLAGS_csv.isEmpty()) {
I think this one has to stay here. I just verifys that the flag is valid (just
like we do for FLAGS_patterns

On 2013/07/19 18:35:08, Zach Reizner wrote:
> Move output handling to the area below "if (!FLAGS_output.isEmpty())"

[djsollen, 2013-07-22 14:11:50]

lgtm from my perspective. Zach anything else stand out to you?

[Zach Reizner, 2013-07-22 14:21:43]

lgtm

[commit-bot: I haz the power, 2013-07-22 15:13:11]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/edisonn@google.com/19826002/32001

[commit-bot: I haz the power, 2013-07-22 15:21:53]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[edisonn, 2013-07-22 15:24:28]

Committed patchset #9 manually as r10234 (presubmit successful).