Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 198253004: Introduce per-isolate assert scopes and API to guard JS execution. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Introduce per-isolate assert scopes and API to guard JS execution. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20062

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : check in release mode + untoggle scope #

Patch Set 4 : simplify #

Patch Set 5 : add missing file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -92 lines) Patch
M include/v8.h View 1 2 3 1 chunk +26 lines, -0 lines 1 comment Download
M src/api.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M src/assert-scope.h View 1 2 3 5 chunks +99 lines, -20 lines 0 comments Download
A src/assert-scope.cc View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 4 chunks +3 lines, -26 lines 0 comments Download
M src/heap.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap-inl.h View 4 chunks +8 lines, -26 lines 0 comments Download
M src/isolate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 chunks +24 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-14 13:36:10 UTC) #1
Yang
On 2014/03/14 13:36:10, Yang wrote: Simplified slightly.
6 years, 9 months ago (2014-03-18 08:39:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/198253004/diff/80001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/198253004/diff/80001/include/v8.h#newcode4084 include/v8.h:4084: }; can you add copy and assign declarations? ...
6 years, 9 months ago (2014-03-19 11:13:16 UTC) #3
Yang
6 years, 9 months ago (2014-03-19 11:31:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r20062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698