Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: tools/gn/bundle_data.cc

Issue 1982463002: [Mac/GN] Treat create_bundle as a leaf for `gn desc runtime_deps`. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return as dir Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_data.h ('k') | tools/gn/runtime_deps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_data.cc
diff --git a/tools/gn/bundle_data.cc b/tools/gn/bundle_data.cc
index f211c1ff0881b5fad4d3278ed8645f4f34cdb95b..e1823653ba497cc7ec8764712a1f369dd1287391 100644
--- a/tools/gn/bundle_data.cc
+++ b/tools/gn/bundle_data.cc
@@ -129,3 +129,8 @@ SourceFile BundleData::GetBundleRootDirOutput(const Settings* settings) const {
}
return SourceFile(root_dir().value());
}
+
+SourceDir BundleData::GetBundleRootDirOutputAsDir(
+ const Settings* settings) const {
+ return SourceDir(GetBundleRootDirOutput(settings).value());
sdefresne 2016/05/17 18:45:36 I think you need to add the trailing "/" when call
Robert Sesek 2016/05/17 18:49:34 SourceFile DCHECKs if there is a slash, but Source
sdefresne 2016/05/18 08:08:41 Ah good.
+}
« no previous file with comments | « tools/gn/bundle_data.h ('k') | tools/gn/runtime_deps.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698