Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1982413002: Fix "break" vs "continue" bug in js interop codegen that was the real source of missing js interop … (Closed)

Created:
4 years, 7 months ago by Jacob
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix "break" vs "continue" bug in js interop codegen that was the real source of missing js interop stubs not using codegenWorld vs resolutionWorld. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/be5c8e1a33ec80d03928c8513d9db6e78e279e95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 5 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jacob
Who was the idiot who wrote this code? Oh wait that was me.
4 years, 7 months ago (2016-05-17 16:47:26 UTC) #2
sra1
lgtm
4 years, 7 months ago (2016-05-17 17:40:12 UTC) #3
Jacob
Committed patchset #1 (id:1) manually as be5c8e1a33ec80d03928c8513d9db6e78e279e95 (presubmit successful).
4 years, 7 months ago (2016-05-17 17:42:31 UTC) #5
Siggi Cherem (dart-lang)
lgtm! good find! Do you think this would fix that var-arg test that started failing ...
4 years, 7 months ago (2016-05-17 19:15:53 UTC) #6
Jacob
4 years, 7 months ago (2016-05-17 20:24:37 UTC) #7
Message was sent while issue was closed.
On 2016/05/17 19:15:53, Siggi Cherem (dart-lang) wrote:
> lgtm! good find!
> 
> Do you think this would fix that var-arg test that started failing with the
> previous CL?

It would due to switching back to codegenWorld. Switching from break to continue
should have no impact for that test.

Powered by Google App Engine
This is Rietveld 408576698