Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1982323002: Revert of Change to sRGB default for codec generated images. (Closed)

Created:
4 years, 7 months ago by herb_g
Modified:
4 years, 7 months ago
Reviewers:
msarett, Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Change to sRGB default for codec generated images. (patchset #2 id:20001 of https://codereview.chromium.org/1955063002/ ) Reason for revert: TBR=brianosman@google.com Original issue's description: > Change to sRGB default for codec generated images. > > Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955063002 > > Committed: https://skia.googlesource.com/skia/+/7acc00853174361cf921ecac8fbeaf6812f53eed TBR=brianosman@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/835acc7619fc3f07658d868b12a7f869daad99d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkImageInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
herb_g
Created Revert of Change to sRGB default for codec generated images.
4 years, 7 months ago (2016-05-17 13:50:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982323002/1
4 years, 7 months ago (2016-05-17 13:50:11 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 13:50:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/835acc7619fc3f07658d868b12a7f869daad99d0

Powered by Google App Engine
This is Rietveld 408576698