Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1982313002: Re-evaluate ShapeResult::m_hasVerticalOffsets after applying spacing (Closed)

Created:
4 years, 7 months ago by f(malita)
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-evaluate ShapeResult::m_hasVerticalOffsets after applying spacing ShapeResult::applySpacing() may introduce vertical offsets, so we need to update m_hasVerticalOffsets also. BUG=610645 R=drott@chromium.org Committed: https://crrev.com/239180b1fd08ebcf0f3098c1238077f6c0998588 Cr-Commit-Position: refs/heads/master@{#394352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
A + third_party/WebKit/LayoutTests/fast/text/vertical-spacing-crash.html View 1 chunk +4 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/vertical-spacing-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
f(malita)
4 years, 7 months ago (2016-05-17 13:49:13 UTC) #1
drott
Sweet, that would have taken me a long time. LGTM!
4 years, 7 months ago (2016-05-18 07:36:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982313002/1
4 years, 7 months ago (2016-05-18 07:36:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 07:40:58 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 07:43:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/239180b1fd08ebcf0f3098c1238077f6c0998588
Cr-Commit-Position: refs/heads/master@{#394352}

Powered by Google App Engine
This is Rietveld 408576698