Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1982303003: Reuse more dialog code for new task manager. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
afakhry, ncarter (slow), sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse more dialog code for new task manager. BUG=571500 Committed: https://crrev.com/710d42bb65ccb87d2fac49f184f2f0d31fe85712 Cr-Commit-Position: refs/heads/master@{#394293}

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : simpler #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -82 lines) Patch
M chrome/browser/ui/views/new_task_manager_view.h View 7 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/new_task_manager_view.cc View 1 2 8 chunks +47 lines, -71 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
Evan Stade
4 years, 7 months ago (2016-05-17 22:34:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982303003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982303003/40001
4 years, 7 months ago (2016-05-17 22:35:42 UTC) #4
sky
LGTM
4 years, 7 months ago (2016-05-18 00:07:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1982303003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1982303003/40001
4 years, 7 months ago (2016-05-18 00:10:50 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 00:40:05 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/710d42bb65ccb87d2fac49f184f2f0d31fe85712 Cr-Commit-Position: refs/heads/master@{#394293}
4 years, 7 months ago (2016-05-18 00:42:31 UTC) #11
ncarter (slow)
lgtm
4 years, 7 months ago (2016-05-18 01:05:01 UTC) #13
afakhry
4 years, 7 months ago (2016-05-19 00:49:43 UTC) #15
Message was sent while issue was closed. 
https://codereview.chromium.org/1982303003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/new_task_manager_view.cc (right):

https://codereview.chromium.org/1982303003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/new_task_manager_view.cc:341:
RetrieveSavedAlwaysOnTopState();
Thanks for catching that typo.

Powered by Google App Engine
This is Rietveld 408576698